Skip to content

[tests] make tests device-agnostic (part 4) - #10508

Merged
hlky merged 48 commits into
huggingface:mainfrom
faaany:xpu-enabling2
Mar 4, 2025
Merged

[tests] make tests device-agnostic (part 4)#10508
hlky merged 48 commits into
huggingface:mainfrom
faaany:xpu-enabling2

Conversation

@faaany

@faaanyfaaany commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Follow up of PR #10437

faaanyand others added 29 commits January 2, 2025 21:36
@faaany
initial comit
8d0f387
@faaany
fix empty cache
88919c0
@faaany
fix one more
e32a9ac
@faaany
fix style
cb7d9d5
@faaany
update device functions
a393860
@faaany
update
2f3ad32
@faaany
update
f3a519f
@faaany
Merge branch 'main' into xpu-enabling
b402629
@faaany@hlky
Update src/diffusers/utils/testing_utils.py
d1532d2
Co-authored-by: hlky <hlky@hlky.ac>
@faaany@hlky
Update src/diffusers/utils/testing_utils.py
16cca22
Co-authored-by: hlky <hlky@hlky.ac>
@faaany@hlky
Update src/diffusers/utils/testing_utils.py
3420e1f
Co-authored-by: hlky <hlky@hlky.ac>
@faaany@hlky
Update tests/pipelines/controlnet/test_controlnet.py
d15618b
Co-authored-by: hlky <hlky@hlky.ac>
@faaany@hlky
Update src/diffusers/utils/testing_utils.py
e814635
Co-authored-by: hlky <hlky@hlky.ac>
@faaany@hlky
Update src/diffusers/utils/testing_utils.py
e799516
Co-authored-by: hlky <hlky@hlky.ac>
@faaany@hlky
Update tests/pipelines/controlnet/test_controlnet.py
d3e8678
Co-authored-by: hlky <hlky@hlky.ac>
@faaany
with gc.collect
fed282b
@faaany
update
8577a14
@faaany
Merge branch 'huggingface:main' into xpu-enabling
f08a849
@hlky
make style
35d7a7a
@hlky
Merge branch 'main' into xpu-enabling
736cc7c
@hlky
check_torch_dependencies
c8661f0
@faaany
Merge branch 'main' into xpu-enabling
d4266a7
@faaany
add mps empty cache
d820f75
@faaany
add changes
6ed4523
@faaany
bug fix
b813f16
@faaany
Merge branch 'xpu-enabling' into xpu-enabling2
c091bcc
@faaany
enable on xpu
f6ae056
@faaany
Merge branch 'main' into xpu-enabling2
013f555
@faaany
update more cases
bb49cab
@faaany
faaany marked this pull request as ready for review January 22, 2025 02:01
@faaany

faaany commented Jan 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@hlky

@faaany

faaany commented Feb 5, 2025

Copy link
Copy Markdown
ContributorAuthor

Hi @sayakpaul@hlky@DN6 , could we proceed with this PR? Thx a lot!

sayakpaul
sayakpaul reviewed Feb 7, 2025
View reviewed changes

@sayakpaulsayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very nuch. Just a single comment for clarification.

Comment threadtests/lora/test_lora_layers_sd.py
@hlky

hlky commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

@bot /style

@hlky

hlky commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

@bot /style

hlky
hlky approved these changes Feb 27, 2025
View reviewed changes

@hlkyhlky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faaany

Comment threadtests/pipelines/stable_diffusion/test_stable_diffusion.py
Comment threadtests/pipelines/stable_diffusion/test_stable_diffusion.py
Comment threadtests/pipelines/stable_diffusion/test_stable_diffusion_img2img.py
Comment threadtests/pipelines/stable_diffusion/test_stable_diffusion_img2img.py
Comment threadtests/pipelines/stable_diffusion/test_stable_diffusion_img2img.py
Comment threadtests/pipelines/stable_diffusion/test_stable_diffusion_instruction_pix2pix.py
Comment threadtests/pipelines/stable_diffusion_2/test_stable_diffusion_inpaint.py
Comment threadtests/pipelines/stable_diffusion_2/test_stable_diffusion_v_pred.py
Comment threadtests/pipelines/stable_diffusion_image_variation/test_stable_diffusion_image_variation.py
Comment threadtests/pipelines/stable_diffusion_xl/test_stable_diffusion_xl_inpaint.py
@hlky

hlky commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

@faaany If you go to the Files tab you can add multiple suggestions to a batch and commit them at once, this avoids many notifications for maintainers.

faaanyand others added 2 commits February 27, 2025 15:22
@faaany

faaany commented Feb 27, 2025

Copy link
Copy Markdown
ContributorAuthor

@faaany If you go to the Files tab you can add multiple suggestions to a batch and commit them at once, this avoids many notifications for maintainers.

Thanks so much for the correction! Code Updated.

@hlky

hlky commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Failing tests are unrelated.

@hlky
hlky merged commit 7855ac5 into huggingface:mainMar 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6DN6DN6 left review comments
@sayakpaulsayakpaulsayakpaul approved these changes
+2 more reviewers
@shethaaditshethaaditshethaadit approved these changes
@hlkyhlkyhlky approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@faaany@hlky@DN6@shethaadit@sayakpaul