Uh oh!
There was an error while loading. Please reload this page.
[tests] make tests device-agnostic (part 3) - #10437
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hlky
left a comment
There was a problem hiding this comment.
I've added some more suggestions and comments. Happy to assist with replicating the requested changes to all areas, let me know!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
Co-authored-by: hlky <hlky@hlky.ac>
faaany
commented
Jan 7, 2025
Thanks so much for the suggestions! code updated. And for further replication, I will submit a follow-up PR today. And for the rest, I would be very happy if you could help. |
faaany
commented
Jan 7, 2025
Do you really need "BACKEND_RESET_MAX_MEMORY_ALLOCATED"? This function will all |
hlky
commented
Jan 7, 2025
We can look at this in another PR. |
HuggingFaceDocBuilderDev
commented
Jan 7, 2025
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
left a comment
There was a problem hiding this comment.
This looks very promising! Thank you!
Have you run the tests for which the changes are being introduced in this PR?
Uh oh!
There was an error while loading. Please reload this page.
faaany
commented
Jan 8, 2025
yes, I run the tests on xpu and except |
hlky
commented
Jan 8, 2025
@faaany |
faaany
commented
Jan 8, 2025
sure, let me update. |
faaany
commented
Jan 9, 2025
Hi @sayakpaul@hlky@DN6 , could you do final-round review? Since I will have follow-up PRs, it would be great that it could be merged this week. Thanks a lot! |
faaany
commented
Jan 14, 2025
Hi folks, any feedback? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What does this PR do?
Followed by PR #9399 and #9400 , this PR further makes current cuda-only tests device-agnostic.