Skip to content

migrate wan lora tests to the pipeline-level mixins - #14613

Merged
sayakpaul merged 5 commits into
huggingface:mainfrom
akshan-main:wan-lora-migration
Aug 27, 2026
Merged

migrate wan lora tests to the pipeline-level mixins#14613
sayakpaul merged 5 commits into
huggingface:mainfrom
akshan-main:wan-lora-migration

Conversation

@akshan-main

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates the Wan pipeline LoRA tests from tests/lora/test_lora_layers_wan.py to the pipeline-level mixins from #14268, following the Flux port: TestWanPipelineLoRA(WanPipelineTesterConfig, LoraTesterMixin) and TestWanPipelineLoRAMemory(WanPipelineTesterConfig, LoraMemoryTesterMixin) in tests/pipelines/wan/test_wan.py, and the old file removed.

The old file's specifics dissolve into the new structure: the text-encoder tests skip through _lora_loadable_modules (Wan loads LoRA into the transformers only), the two "Not supported in Wan" block-scale skips disappear since those tests now live in UNetLoraTesterMixin, and the old 9e-3 tolerance overrides are not needed at the mixin defaults (verified by running the classes). Follows #14268.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you read our philosophy doc (important for complex PRs)?
  • Was this discussed/approved via a GitHub issue or the forum? Discussed on Slack with @sayakpaul
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@sayakpaul

@github-actions github-actions Bot added size/M PR with diff < 200 LOC tests size/L PR with diff > 200 LOC and removed size/M PR with diff < 200 LOC labels Aug 27, 2026
@github-actions github-actions Bot added size/M PR with diff < 200 LOC and removed size/L PR with diff > 200 LOC labels Aug 27, 2026
@sayakpaul

Copy link
Copy Markdown
Member

/diffusers-bot pytest tests/pipelines/wan/test_wan.py -k "lora"

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

pytest tests/pipelines/wan/test_wan.py -k "lora" passed on GPU — view logs.

@sayakpaul
sayakpaul merged commit 913ab22 into huggingface:main Aug 27, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M PR with diff < 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants