migrate wan vace lora tests to the pipeline-level mixins - #14614
Merged
Conversation
6 tasks
sayakpaul
approved these changes
Aug 27, 2026
Member
|
/diffusers-bot pytest tests/pipelines/wan/test_wan_vace.py -k "lora" |
Contributor
|
✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates the Wan VACE pipeline LoRA tests from
tests/lora/test_lora_layers_wanvace.pyto the pipeline-level mixins from #14268, same shape as #14613:TestWanVACEPipelineLoRA(WanVACEPipelineTesterConfig, LoraTesterMixin)andTestWanVACEPipelineLoRAMemory(WanVACEPipelineTesterConfig, LoraMemoryTesterMixin)intests/pipelines/wan/test_wan_vace.py, and the old file removed.The VACE-specific
exclude_modulestest is ported as a method on the new class (targetsproj_outwhile excludingvace_blocks.0.proj_out, with the save/load round-trip checks). The old file's other specifics dissolve the same way as in #14613: text-encoder tests skip through_lora_loadable_modules, the block-scale skips disappear withUNetLoraTesterMixin, and the tolerance overrides are not needed at the mixin defaults. Follows #14613.Before submitting
Who can review?
@sayakpaul