Skip to content

migrate wan vace lora tests to the pipeline-level mixins - #14614

Merged
sayakpaul merged 2 commits into
huggingface:mainfrom
akshan-main:wanvace-lora-migration
Aug 27, 2026
Merged

migrate wan vace lora tests to the pipeline-level mixins#14614
sayakpaul merged 2 commits into
huggingface:mainfrom
akshan-main:wanvace-lora-migration

Conversation

@akshan-main

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates the Wan VACE pipeline LoRA tests from tests/lora/test_lora_layers_wanvace.py to the pipeline-level mixins from #14268, same shape as #14613: TestWanVACEPipelineLoRA(WanVACEPipelineTesterConfig, LoraTesterMixin) and TestWanVACEPipelineLoRAMemory(WanVACEPipelineTesterConfig, LoraMemoryTesterMixin) in tests/pipelines/wan/test_wan_vace.py, and the old file removed.

The VACE-specific exclude_modules test is ported as a method on the new class (targets proj_out while excluding vace_blocks.0.proj_out, with the save/load round-trip checks). The old file's other specifics dissolve the same way as in #14613: text-encoder tests skip through _lora_loadable_modules, the block-scale skips disappear with UNetLoraTesterMixin, and the tolerance overrides are not needed at the mixin defaults. Follows #14613.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you read our philosophy doc (important for complex PRs)?
  • Was this discussed/approved via a GitHub issue or the forum? Discussed on Slack with @sayakpaul
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@sayakpaul

@sayakpaul

Copy link
Copy Markdown
Member

/diffusers-bot pytest tests/pipelines/wan/test_wan_vace.py -k "lora"

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

pytest tests/pipelines/wan/test_wan_vace.py -k "lora" passed on GPU — view logs.

@sayakpaul
sayakpaul merged commit c14a1e8 into huggingface:main Aug 27, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L PR with diff > 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants