Skip to content

Addition of new callbacks to controlnets - #5812

Merged
patrickvonplaten merged 7 commits into
huggingface:mainfrom
a-r-r-o-w:callbacks
Nov 21, 2023
Merged

Addition of new callbacks to controlnets#5812
patrickvonplaten merged 7 commits into
huggingface:mainfrom
a-r-r-o-w:callbacks

Conversation

@a-r-r-o-w

@a-r-r-o-wa-r-r-o-w commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes#5811, #5798

Before submitting

Who can review?

@yiyixuxu@patrickvonplaten

@a-r-r-o-w

a-r-r-o-w commented Nov 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@yiyixuxu Could you let me know if the parameters like controlnet_conditioning_scale, control_guidance_start, control_guidance_end should also be @property-ified, like guidance_scale? Will add the changes to all pipelines accordingly?

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Nov 15, 2023•
edited
Loading

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@a-r-r-o-w

a-r-r-o-w commented Nov 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Could you also let me know what to do with pipeline_controlnet_blip_diffusion.py? It did not support any callback parameters before, so I haven't added any new parameters either.

@a-r-r-o-w

a-r-r-o-w commented Nov 15, 2023

Copy link
Copy Markdown
ContributorAuthor

Apart from controlnet pipelines, multiple other pipelines that support callbacks do not yet support the latest callback implementation. I'd be happy to work on adding those.

@yiyixuxu

yiyixuxu commented Nov 16, 2023

Copy link
Copy Markdown
Collaborator

@a-r-r-o-w

Could you let me know if the parameters like controlnet_conditioning_scale, control_guidance_start, control_guidance_end should also be @property-ified, like guidance_scale? Will add the changes to all pipelines accordingly?

Let's not add them for now! we can add them in the future when we get a feature request and need to support a meaningful user case :)

yiyixuxu
yiyixuxu approved these changes Nov 16, 2023
View reviewed changes

@yiyixuxuyiyixuxu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! look great!

@yiyixuxu

yiyixuxu commented Nov 16, 2023

Copy link
Copy Markdown
Collaborator

Apart from controlnet pipelines, multiple other pipelines that support callbacks do not yet support the latest callback implementation. I'd be happy to work on adding those.

yes sure if you're happy to:)

@a-r-r-o-w

a-r-r-o-w commented Nov 16, 2023

Copy link
Copy Markdown
ContributorAuthor

@patil-suraj There were a few merge conflicts after #5822. Could you verify if I've merged it correctly?

@a-r-r-o-wa-r-r-o-w changed the title Addition of new callbacksAddition of new callbacks to controlnetsNov 16, 2023
@a-r-r-o-w

a-r-r-o-w commented Nov 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Failing tests seem unrelated

@patrickvonplaten

patrickvonplaten commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Great job @a-r-r-o-w

@patrickvonplaten
patrickvonplaten merged commit 8178088 into huggingface:mainNov 21, 2023
affromero pushed a commit to affromero/diffusers that referenced this pull request Nov 24, 2023
@a-r-r-o-w@patrickvonplatenandres
Addition of new callbacks to controlnets (huggingface#5812)
db71a80
* add new callbacks to src/diffusers/pipelines/controlnet/pipeline_controlnet.py
* update callbacks
* fix repeated kwarg
* update
---------
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@a-r-r-o-w@patrickvonplaten
Addition of new callbacks to controlnets (huggingface#5812)
e8b4f41
* add new callbacks to src/diffusers/pipelines/controlnet/pipeline_controlnet.py
* update callbacks
* fix repeated kwarg
* update
---------
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
@a-r-r-o-w
a-r-r-o-w deleted the callbacks branch January 4, 2024 14:34
@yiyixuxuyiyixuxu mentioned this pull request Feb 28, 2024
Closed
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@a-r-r-o-w@patrickvonplatenJimmy
Addition of new callbacks to controlnets (huggingface#5812)
7d45f92
* add new callbacks to src/diffusers/pipelines/controlnet/pipeline_controlnet.py
* update callbacks
* fix repeated kwarg
* update
---------
Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxuyiyixuxuyiyixuxu approved these changes
@patrickvonplatenpatrickvonplatenAwaiting requested review from patrickvonplaten

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Callbacks] adding callback_on_step_end arguments to all pipelines

4 participants

@a-r-r-o-w@HuggingFaceDocBuilderDev@yiyixuxu@patrickvonplaten