Skip to content

make pipelines tests device-agnostic (part1) - #9399

Merged
DN6 merged 72 commits into
huggingface:mainfrom
faaany:enable_xpu
Nov 22, 2024
Merged

make pipelines tests device-agnostic (part1)#9399
DN6 merged 72 commits into
huggingface:mainfrom
faaany:enable_xpu

Conversation

@faaany

@faaanyfaaany commented Sep 9, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Below are some evidences:

PASSED tests/pipelines/animatediff/test_animatediff.py::AnimateDiffPipelineFastTests::test_to_device
PASSED tests/pipelines/amused/test_amused.py::AmusedPipelineFastTests::test_model_cpu_offload_forward_pass
PASSED tests/pipelines/amused/test_amused.py::AmusedPipelineFastTests::test_cpu_offload_
forward_pass_twice
PASSED tests/pipelines/amused/test_amused_inpaint.py::AmusedInpaintPipelineFastTests::te
st_to_device

@yiyixuxu

@faaany
faaany marked this pull request as ready for review September 9, 2024 22:55
@sayakpaul

sayakpaul commented Sep 10, 2024

Copy link
Copy Markdown
Member

Could you provide some details about the machine you used to run the tests changed in this PR?

@faaany

faaany commented Sep 10, 2024

Copy link
Copy Markdown
ContributorAuthor

Could you provide some details about the machine you used to run the tests changed in this PR?

yes, I am running on Intel(R) Data Center GPU Max 1550.

@faaany

faaany commented Sep 10, 2024

Copy link
Copy Markdown
ContributorAuthor

Could you provide some details about the machine you used to run the tests changed in this PR?

xpu is the common device name for intel gpu.

@faaany

faaany commented Sep 12, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi @sayakpaul , any concern on this PR?

@faaany

faaany commented Sep 13, 2024

Copy link
Copy Markdown
ContributorAuthor

could you pls help retrigger the CI? Thx a lot!

yiyixuxu
yiyixuxu reviewed Nov 8, 2024
View reviewed changes
Comment threadtests/pipelines/deepfloyd_if/test_if.py Outdated
DN6
DN6 reviewed Nov 8, 2024
View reviewed changes
Comment threadsrc/diffusers/utils/testing_utils.py Outdated
Comment threadtests/pipelines/animatediff/test_animatediff.py Outdated
Comment threadtests/pipelines/animatediff/test_animatediff_controlnet.py Outdated
Comment threadtests/pipelines/animatediff/test_animatediff_controlnet.py Outdated
Comment threadtests/pipelines/deepfloyd_if/test_if.py Outdated
@faaany

faaany commented Nov 11, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for the comments. Code Update!

@IlyasMoutawwakil

IlyasMoutawwakil commented Nov 18, 2024

Copy link
Copy Markdown
Member

@faaany can you please run styling on this branch and apply the same comments to part 2 PR ? (require_non_cpu is still defined and used there)

@faaany

faaany commented Nov 18, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@faaany can you please run styling on this branch and apply the same comments to part 2 PR ? (require_non_cpu is still defined and used there)

Thanks for the review! Style fixed and let me un-draft the part2 PR, once this one got merged

@IlyasMoutawwakil

IlyasMoutawwakil commented Nov 18, 2024

Copy link
Copy Markdown
Member

@faaany your changes didn't pass the code quality check, can you do make style && make quality

@faaany

faaany commented Nov 18, 2024

Copy link
Copy Markdown
ContributorAuthor

@faaany your changes didn't pass the code quality check, can you do make style && make quality

done

a-r-r-o-w
a-r-r-o-w approved these changes Nov 18, 2024
View reviewed changes

@a-r-r-o-wa-r-r-o-w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the awesome work here! I think this looks good to merge and the failing tests are unrelated (I've restarted them anyway to make it go away). Off to @DN6 for merging since he has much more experience on the tests front

@a-r-r-o-w
a-r-r-o-w requested a review from DN6November 18, 2024 20:41
@faaany

faaany commented Nov 21, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi @DN6 , could you take a look at this PR?

DN6
DN6 approved these changes Nov 22, 2024
View reviewed changes
@DN6
DN6 merged commit 64b3e0f into huggingface:mainNov 22, 2024
lawrence-cj pushed a commit to lawrence-cj/diffusers that referenced this pull request Nov 26, 2024
@faaany@sayakpaul
@DN6@lawrence-cj
makepipelinestests device-agnostic (part1) (huggingface#9399)
788734b
* enable on xpu
* add 1 more
* add one more
* enable more
* add 1 more
* add more
* enable 1
* enable more cases
* enable
* enable
* update comment
* one more
* enable 1
* add more cases
* enable xpu
* add one more caswe
* add more cases
* add 1
* add more
* add more cases
* add case
* enable
* add more
* add more
* add more
* enbale more
* add more
* update code
* update test marker
* add skip back
* update comment
* remove single files
* remove
* style
* add
* revert
* reformat
* update decorator
* update
* update
* update
* Update tests/pipelines/deepfloyd_if/test_if.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* Update src/diffusers/utils/testing_utils.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* Update tests/pipelines/animatediff/test_animatediff_controlnet.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* Update tests/pipelines/animatediff/test_animatediff.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* Update tests/pipelines/animatediff/test_animatediff_controlnet.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* update float16
* no unitest.skipt
* update
* apply style check
* reapply format
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
sayakpaul added a commit that referenced this pull request Dec 23, 2024
@faaany@sayakpaul@DN6
makepipelinestests device-agnostic (part1) (#9399)
527b79d
* enable on xpu
* add 1 more
* add one more
* enable more
* add 1 more
* add more
* enable 1
* enable more cases
* enable
* enable
* update comment
* one more
* enable 1
* add more cases
* enable xpu
* add one more caswe
* add more cases
* add 1
* add more
* add more cases
* add case
* enable
* add more
* add more
* add more
* enbale more
* add more
* update code
* update test marker
* add skip back
* update comment
* remove single files
* remove
* style
* add
* revert
* reformat
* update decorator
* update
* update
* update
* Update tests/pipelines/deepfloyd_if/test_if.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* Update src/diffusers/utils/testing_utils.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* Update tests/pipelines/animatediff/test_animatediff_controlnet.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* Update tests/pipelines/animatediff/test_animatediff.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* Update tests/pipelines/animatediff/test_animatediff_controlnet.py
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
* update float16
* no unitest.skipt
* update
* apply style check
* reapply format
---------
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
@faaanyfaaany mentioned this pull request Jan 3, 2025
Merged
@yao-matrixyao-matrix mentioned this pull request Apr 29, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxuyiyixuxuyiyixuxu left review comments
@DN6DN6DN6 approved these changes
@sayakpaulsayakpaulsayakpaul approved these changes
+1 more reviewer
@a-r-r-o-wa-r-r-o-wa-r-r-o-w approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@faaany@sayakpaul@HuggingFaceDocBuilderDev@yao-matrix@IlyasMoutawwakil@DN6@yiyixuxu@a-r-r-o-w