Uh oh!
There was an error while loading. Please reload this page.
feat: add GracefulShutdown helper - #127
Merged
Merged
Conversation
seanmonstar
commented
May 27, 2024
Uh oh!
There was an error while loading. Please reload this page.
GlenDC
commented
May 27, 2024
Thx. I currently have no time. So I’ll review instead :3 |
GlenDC
approved these changes
May 27, 2024
GlenDC
left a comment
There was a problem hiding this comment.
I have a feeling you're not ready yet. But this does look a whole lot simpler indeed!
Not surprising of course, as there is a pay off. Fully respect the approach though, and pays of it self indeed. Thx for picking up the work, and all your hard work in general!!!
seanmonstarforce-pushed
the
graceful
branch
2 times, most recently
from
May 28, 2024 12:27
8ab37af to
131bf3eCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
hyper_util::server::graceful::GracefulShutdownhelper, which can be used to watch connections, and then trigger a graceful shutdown and await all connections finishing.Continues off of #108. cc @GlenDC
Closeshyperium/hyper#2862