Uh oh!
There was an error while loading. Please reload this page.
feat: add auto Connection::into_owned - #128
Merged
Merged
Conversation
seanmonstarforce-pushed
the
auto-conn-into-owned
branch
from
May 27, 2024 17:12
6fe1c3d to
9e84855Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when trying to make use of #127 that you cannot currently create and reuse a server builder, and spawn the connections into a new task, because
Connectionborrows theBuilder. (In hindsight, it probably should have just made a clone, but oh well.) This adds the ability to disconnect the lifetimes.