Skip to content

Support regular urls that have a path component - #43

Open
pferruggiaro wants to merge 1 commit into
hyperoslo:masterfrom
pferruggiaro:urls_with_path
Open

Support regular urls that have a path component#43
pferruggiaro wants to merge 1 commit into
hyperoslo:masterfrom
pferruggiaro:urls_with_path

Conversation

@pferruggiaro

Copy link
Copy Markdown
Contributor

Constructs the Location.path based on the URL.host + URL.path, so that URLs such as scheme://callback/path are supported.

@mention-bot

Copy link
Copy Markdown

@pferruggiaro, thanks for your PR! By analyzing the history of the files in this pull request, we identified @onmyway133, @vadymmarkov and @zenangst to be potential reviewers.

@zenangst

Copy link
Copy Markdown
Contributor

This is great, thanks @pferruggiaro.

What do you guys think @hyperoslo/ios

@vadymmarkov

Copy link
Copy Markdown
Contributor

I like it @pferruggiaro

@onmyway133

Copy link
Copy Markdown
Contributor

Last time we support delimiterhttps://github.com/hyperoslo/Compass/blob/master/Sources/Compass.swift#L12 so that people don't have to to use the default :

@pferruggiaro is this what you mean?

@pferruggiaro

Copy link
Copy Markdown
ContributorAuthor

@onmyway133 Possibly...
I can see how switching the delimiter to / would enable a URL like user/list/{userId}/{kind}, but my goal is to support a standard URL that includes a host, path, and query params such as targetapp://x-callback-url/updateStatus?x-source=SourceApp&text=test123

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@pferruggiaro@mention-bot@zenangst@vadymmarkov@onmyway133