Uh oh!
There was an error while loading. Please reload this page.
refactor: use the Buffer and BoundingBox types to perform the communication packing / unpacking in Axis & ConstrainedTransport classes - #385
Merged
glesur merged 8 commits intoJul 8, 2026
Conversation
…ion and validate they are identic)
… code after cross validation)
…nstrainedTransport (step 1)
…hes in axis.cpp (step 4)
svalatforce-pushed
the
refactor/mpi-exchanges-use-buffer-packer
branch
from
July 6, 2026 11:38
1734561 to
986505bCompareglesur
approved these changes
Jul 8, 2026
Uh oh!
There was an error while loading. Please reload this page.
svalat added a commit
to svalat/idefix
that referenced
this pull request
Aug 17, 2026
glesur pushed a commit
that referenced
this pull request
Aug 18, 2026
… ./test.py (#399) * test: Fix missing protagation of return status when calling pytest in ./test.py * fix: fix an issue coming from the previous refactoring about accessing a GPU buffer on CPU * fix: Fix some warnings about unused variabled blocking the test suite * test: fix utils/lookupTable test by adding possibility to call a python function from testme.json * fix: communication issue introduced during the comm refactoring in recent commit of PR #385. * fix: add missing new file testmelib.py in test/utils/lookupTable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the hand made buffer packing by using
BoundingBoxandBufferinto theAxisclass in preparation to a larger refactoring to latter use theExchangerclass intoAxisto manage the communications.Process made in 3 steps
Needed a add
UnpackJDirSymetric()inBufferclass.Validation
Squash
I let the steps commits in the branch, but they can be squashed for the merge in
develop.