Skip to content

test: Fix missing propagation of return status when calling pytest in ./test.py - #399

Merged
glesur merged 8 commits into
idefix-code:developfrom
svalat:fix/test-suite-return-status
Aug 18, 2026
Merged

test: Fix missing propagation of return status when calling pytest in ./test.py#399
glesur merged 8 commits into
idefix-code:developfrom
svalat:fix/test-suite-return-status

Conversation

@svalat

@svalatsvalat commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Big ooops, forgot to return the pytest status to propagate it as it does not throw an exception.

Also fix issues to make the test suite green again :

  • Access to a GPU cell from CPU in previous communication refactoring.
  • Missing call to a python function for a test
  • Wrong array used in a previous refactoring about MPI communications.
  • Fix a warning due to unused variable

Python call in testme.json

In order to fix the missing call the MakeNumpyFile() function in the test test/utils/lookupTable I added in this PR a new semantic in the test suite to be able to call a Python function from the testme.json test definition.

It is simply two new fields which can be used :

"default": {
"callPyFunctionBefore": "testmelib.py:callMeAtStart",
"callPyFunctionAfter": "testmelib.py:callMeAtEnd"
}

It will call callMeAtStart before running the test and callMeAtEnd at the end of the test, the two functions beeing defined in testmelib.py.

Note: the documentation has been updated.

@svalatsvalat added the bug Something isn't working label Aug 14, 2026
@svalat
svalatforce-pushed the fix/test-suite-return-status branch from c49661d to a2421e6CompareAugust 14, 2026 15:40
@glesur
glesur self-requested a review August 17, 2026 14:47
@svalatsvalat changed the title test: Fix missing protagation of return status when calling pytest in ./test.pytest: Fix missing propagation of return status when calling pytest in ./test.pyAug 18, 2026
@glesur
glesur merged commit 1e23562 into idefix-code:developAug 18, 2026
41 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@svalat@glesur