Skip to content

make LoopKernel.__init__ leaner - #293

Merged
inducer merged 5 commits into
mainfrom
make_kernel_constructor_leaner
Jun 10, 2021
Merged

make LoopKernel.__init__ leaner#293
inducer merged 5 commits into
mainfrom
make_kernel_constructor_leaner

Conversation

@kaushikcfd

@kaushikcfdkaushikcfd commented Apr 14, 2021

Copy link
Copy Markdown
Collaborator

This is done by adding attribute-specific copies so that heavy operations in LoopKernel.init are invoked only when necessary.

@kaushikcfd
kaushikcfdforce-pushed the make_kernel_constructor_leaner branch from 081b466 to 6da6a2bCompareApril 14, 2021 18:27
@kaushikcfd
kaushikcfd requested a review from inducerApril 14, 2021 19:08
inducer
inducer reviewed Apr 14, 2021
View reviewed changes
Comment threadloopy/kernel/__init__.py Outdated
@kaushikcfdkaushikcfd mentioned this pull request Apr 16, 2021
Closed
1 task
kaushikcfd
kaushikcfd commented Apr 16, 2021
View reviewed changes
Comment threadloopy/kernel/__init__.py Outdated
Comment threadloopy/kernel/__init__.py Outdated
@inducer

inducer commented Apr 26, 2021

Copy link
Copy Markdown
Owner

@kaushikcfd I feel like we formed a consensus around this in our meeting Tuesday, but I forgot what it was. Was it to do all this input processing centrally in get_copy_kwargs? Do you remember?

@kaushikcfd

kaushikcfd commented Apr 26, 2021

Copy link
Copy Markdown
CollaboratorAuthor

Was it to do all this input processing centrally in get_copy_kwargs?

Yep, that was it. One method to take care of all the dependencies.

@kaushikcfdkaushikcfd mentioned this pull request Jun 3, 2021
Draft
2 tasks
@kaushikcfd
move get_outer_params out of LoopKernel.__init__
d6abfd9
@kaushikcfd
make LoopKernel.__init__ leaner
0463041
- move domain checks out of it
- trigger domain checks in copy iff it was passed as an input
@kaushikcfd
kaushikcfdforce-pushed the make_kernel_constructor_leaner branch from 41d0591 to 0463041CompareJune 8, 2021 17:20
@kaushikcfd
kaushikcfd requested a review from inducerJune 8, 2021 17:38
inducer
inducer reviewed Jun 10, 2021
View reviewed changes

@inducerinducer left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few minor things noted below, then this LGTM.

Comment threadloopy/kernel/__init__.py Outdated
Comment threadloopy/kernel/__init__.py Outdated
Comment threadloopy/kernel/__init__.py
Comment threadloopy/kernel/__init__.py
@inducer

inducer commented Jun 10, 2021

Copy link
Copy Markdown
Owner

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

@kaushikcfd

kaushikcfd commented Jun 10, 2021•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

@inducer: Thanks for taking a look, I believe this branch is ready.

inducer
inducer approved these changes Jun 10, 2021
View reviewed changes
Comment threadloopy/kernel/__init__.py
@inducer

inducer commented Jun 10, 2021

Copy link
Copy Markdown
Owner

LGTM. Thanks!

@inducer
inducer enabled auto-merge (squash) June 10, 2021 05:36
@inducer
inducer merged commit 2ca42e6 into mainJun 10, 2021
@inducer
inducer deleted the make_kernel_constructor_leaner branch June 10, 2021 06:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inducerinducerinducer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaushikcfd@inducer