Better data structures for LoopKernel.(domains|inames) - #298
Closed
kaushikcfd wants to merge 20 commits into
Closed
Better data structures for LoopKernel.(domains|inames) #298kaushikcfd wants to merge 20 commits into
kaushikcfd wants to merge 20 commits into
Conversation
kaushikcfd
commented
Apr 16, 2021
Collaborator
- Domains: The new LoopKernelDomains class now holds on to some derived variables that are incrementally updated to avoid recomputation during every instantitation.
- Inames: Stores inames in a sparse-sense.
- Depends on make LoopKernel.__init__ leaner #293
kaushikcfdforce-pushed
the
loop_kernel_domains
branch
3 times, most recently
from
April 17, 2021 00:29
c0956d3 to
6bdf0f4Comparekaushikcfdforce-pushed
the
loop_kernel_domains
branch
from
April 26, 2021 13:11
9234751 to
241194fCompare2 tasks
kaushikcfdforce-pushed
the
loop_kernel_domains
branch
from
June 2, 2021 23:52
241194f to
584109aCompareThis is done by adding attribute-specific copies so that heavy operations in LoopKernel.__init__ are invoked only when necessary
* Provides better performance via taking into account incremental updates * Adds :mod:`pyrsistent` as a dep.
* dict would be a dense data structure that would require lead costly LoopKernel copies.
* pyrsistent.PClass doesn't play well with pylint
* adds pyrsistent to list of intersphinx mappings
* LoopKernelDomains.swap(..) exits early if the obtained domain is identical
- there was really no good reason why this was present in the first place - allowing this is a GOOD idea as it allows to have more flexibility in defining fine-grained domains
kaushikcfdforce-pushed
the
loop_kernel_domains
branch
from
June 3, 2021 00:34
584109a to
c3112ccComparekaushikcfd
commented
Jun 3, 2021
CollaboratorAuthor
This PR started depending on #372 in that the current code-generation implementation starts doing wonky updates to the domain which doesn't retain certain assumptions this branch makes like each iname belongs to exactly one home domain. I'm closing this in favor of that. The downside is that #372 starts increasing in volume, but there's no good way to keep them separate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.