dataclasses: make sure inherited classes have correct frozenness - #566
Closed
matthiasdiener wants to merge 4 commits into
Closed
dataclasses: make sure inherited classes have correct frozenness#566matthiasdiener wants to merge 4 commits into
matthiasdiener wants to merge 4 commits into
Conversation
matthiasdiener
force-pushed
the
more-dc-frozenness
branch
from
December 2, 2024 18:14
cc4c965 to
8c3b4f7
Compare
Owner
|
I'm generally OK with this, if the issues are resolvable. |
matthiasdiener
force-pushed
the
more-dc-frozenness
branch
from
December 2, 2024 22:39
fc3fefc to
0e29cb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, code would fail with optimizations enabled:
Followup of #521.