Conversation
inducer
marked this pull request as ready for review
May 2, 2025 20:06
inducer
enabled auto-merge (rebase)
May 2, 2025 20:06
Owner
Author
|
Unfortunately, it seems that this change makes mypy lose it completely. |
Contributor
|
See also #566, which had similar issues. |
inducer
commented
May 2, 2025
Comment on lines
+109
to
+111
| # basedmypy baseline contains spurious errors flagged due to | ||
| # https://github.com/python/mypy/issues/17731 | ||
| # https://github.com/python/mypy/issues/19017 |
Owner
Author
There was a problem hiding this comment.
Co-authored-by: Matthias Diener <mdiener@illinois.edu>
Owner
Author
Thanks for pointing out the similarity! I've included that test here and set a "Closes" in the direction of that PR (since this wholly subsumes it). |
inducer
enabled auto-merge (rebase)
May 2, 2025 22:17
inducer
disabled auto-merge
May 2, 2025 22:18
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #566.
Addresses issues found in illinois-ceesd/drivers_y3-prediction#87 by @majosm.