Add support for parsing dotted names into tags by kaushikcfd · Pull Request #57 · inducer/pytools

kaushikcfd · 2020-12-10T06:32:18Z

No description provided.

inducer

Thanks for working on this. Some initial high-level feedback below.

- shortcuts must be prepended by a "."

- limit line columns length to 85 - install lark-parser for pylint,docs to resolve modules

inducer

Thanks! Some initial comments below.

inducer · 2021-01-11T18:29:57Z

 rm pytools/log.py

- export EXTRA_INSTALL="numpy"
+ export EXTRA_INSTALL="numpy lark-parser"


Could you push a sister MR to Gitlab (add the link to the PR description) to ensure that passes, too?

https://gitlab.tiker.net/inducer/pytools/-/merge_requests/52

inducer · 2021-01-11T21:37:07Z

+TAG_GRAMMAR = """
+ tag: tag_class "(" params ")" -> map_tag_from_python_class
+ | SHORTCUT -> map_tag_from_shortcut
+
+ params: -> map_empty_args_params
+ | args -> map_args_only_params
+ | kwargs -> map_kwargs_only_params
+ | args "," kwargs -> map_args_kwargs_params
+
+ ?kwargs: kwarg
+ | kwargs "," kwarg -> map_kwargs
+
+ args: arg -> map_singleton_args
+ | args "," arg -> map_args
+
+ kwarg: name "=" arg -> map_kwarg
+
+ ?arg: tag
+ | INT -> map_int
+ | ESCAPED_STRING -> map_string
+
+ tag_class: module "." name -> map_tag_class
+
+ module: name -> map_top_level_module
+ | module "." name -> map_nested_module
+
+ name: CNAME -> map_name
+ SHORTCUT: "." ("_"|LETTER) ("_"|LETTER|DIGIT|".")*
+
+ %import common.INT
+ %import common.ESCAPED_STRING
+ %import common.DIGIT
+ %import common.LETTER
+ %import common.CNAME
+ %import common.WS
+ %ignore WS
+"""


Looked over the grammar, looks OK. (Please leave this for me to resolve at final review.)

kaushikcfd · 2021-03-11T06:38:25Z

Probably I should rewrite this as pytools.resolve_name already contains most of the logic.

inducer · 2021-03-12T00:16:37Z

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

inducer · 2021-03-15T00:43:08Z

Probably I should rewrite this as pytools.resolve_name already contains most of the logic.

I actually don't think so. We'll be able to reuse this as we use more lark. Sorry I've been slow to review. Otherwise ready for another look from your end?

inducer reviewed Dec 12, 2020
View reviewed changes

Comment threadpytools/tag.py Outdated
Comment threadsetup.py Outdated
Comment threadtest/testlib.py

kaushikcfd added 6 commits January 4, 2021 14:12

add support for parsing dotted names into tags
c1085fb

add mako, lark to dependencies
016d50b

typo fix
e3196ef

testlib.py -> testlib_tags.py
f585143

static tags parsing grammar
838592a
- shortcuts must be prepended by a "."

removes dep:Mako; makes 'lark' a soft dependency
52599f8

kaushikcfd force-pushed the parse_tag branch 2 times, most recently from 44f0ead to c2f9057Compare January 4, 2021 20:34

formatting
db50fb9
- limit line columns length to 85 - install lark-parser for pylint,docs to resolve modules

kaushikcfd force-pushed the parse_tag branch from c2f9057 to db50fb9Compare January 4, 2021 20:39

kaushikcfd requested a review from inducer January 4, 2021 20:44

Merge branch 'master' into parse_tag
29ec0c3

inducer reviewed Jan 11, 2021
View reviewed changes

Comment threadpytools/tag.py Outdated

inducer reviewed Jan 11, 2021
View reviewed changes

kaushikcfd added 4 commits January 18, 2021 00:42

moves grammar to tags.lark
6583c32

memoize parser construction; remove pytools.tag's hard dep on lark
ff625d9

moves the args flattening inside the mixin
6fb2eb3

Merge branch 'master' into parse_tag
4189294

kaushikcfd mentioned this pull request Mar 8, 2021
No more string tags inducer/loopy#245
Merged
3 tasks

Base automatically changed from master to mainMarch 8, 2021 01:59

Merge branch 'main' into parse_tag
9501b80

Navigation Menu

Add support for parsing dotted names into tags - #57

Add support for parsing dotted names into tags#57
kaushikcfd wants to merge 13 commits into
inducer:mainfrom
kaushikcfd:parse_tag

kaushikcfd commented Dec 10, 2020

Uh oh!

inducer left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inducer left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inducerJan 11, 2021

Uh oh!

kaushikcfdJan 18, 2021

Uh oh!

Uh oh!

inducerJan 11, 2021

Uh oh!

kaushikcfd commented Mar 11, 2021•
edited
Loading

Uh oh!

inducer commented Mar 12, 2021

Uh oh!

inducer commented Mar 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kaushikcfd commented Dec 10, 2020

Uh oh!

inducer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inducer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inducerJan 11, 2021

Choose a reason for hiding this comment

Uh oh!

kaushikcfdJan 18, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

inducerJan 11, 2021

Choose a reason for hiding this comment

Uh oh!

kaushikcfd commented Mar 11, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inducer commented Mar 12, 2021

Uh oh!

inducer commented Mar 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kaushikcfd commented Mar 11, 2021•
edited
Loading