Fix form reset logic - #186
Merged
Merged
Conversation
lstein
requested changes
Aug 29, 2022
lstein
approved these changes
Aug 29, 2022
Collaborator
|
Since @bakkot is now officially a collaborator, and the changes are not so extensive, I'm going to go ahead and merge without the second review. |
austinbrown34
pushed a commit
to cognidesign/InvokeAI
that referenced
this pull request
Dec 30, 2022
Fix form reset logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.reset()method used prior to 18899be wasn't working because there was an input named "reset", which was shadowing the actual method. Doing a full reload is annoying because it loses your prompt and previously-generated images, which is unexpected (at least to me). Also, some browsers remember form inputs during a reload, which makes the button not serve its actual purpose.First two commits are just fixing the whitespace - one to get rid of some tabs, the other to replace CRLFs with LFs. Third commit has the actual fix.
Fixes #185.