webui: hide gfpgan part if not installed - #187
Conversation
dce0d2b to
e34d3ea
Compare
blessedcoolant
left a comment
There was a problem hiding this comment.
Seems good. I'd make 2x the default value for the Upscaling Level dropdown. Currently it is not set to anything on the UI. Rest is good to go.
|
@blessedcoolant I would think upscaling should be opt-in, even if you have GFPGAN set up? So blank (i.e. no upscaling) seems like the right default. Anyway this PR doesn't change the default. |
I guess. But seeing an unfilled element in the UI is never good. I would ideally prefer there to be an option that just says 'None' or something. Not a big issue though. I'm gonna do a full fledged UI when we are done with the big features and we can explore the UI options then. |
Looks like #192 actually does that. |
|
@TesseractCat well, either elements move around during load when it is installed or they move around when it isn't; you can't really avoid that. In practice, when running locally it's close enough to instantaneous that you're not going to see it happen. So I'm going to leave it as-is. |
e34d3ea to
a7a62d3
Compare
|
I'm going to go ahead and merge. If the aesthetics get bothersome we can always tweak later. |
webui: hide gfpgan part if not installed
…umerically Runs every mode on the stock conv3d and then on the conv2d decomposition in one process and reports the drift between the two paths, so a partial revert of the HIP >= 7.2 retirement (invoke-ai#187) can be checked for the allocator-state corruption that motivated it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S4B5exWsbC2z2Uu2tA167A
This has the first two commits from #186 just to avoid merge conflicts. Third commit is the actual logic.
This hides the GFPGAN part of the web UI (and suppresses error messages in the server console) if the GFPGAN model isn't found. I actually don't have GFPGAN installed and so can't test that it still displays when the model actually is installed, but it should.