Uh oh!
There was an error while loading. Please reload this page.
Update Kubo version tested against - #253
Conversation
From ancient 0.18.1 to latest 0.39.0. This causes test breakage as some deprecated endpoints like `object` are dropped.
Once for push and once for pull_request. Observe push ONLY on master
Seems Ant and Maven disagree on multihash artifact: Ant want to build against JAR that does not contains this commit: I'd really vote to clean up the build, drop Ant and drop "hosting" JARs in git repository.... Maven build: pass |
vorburger
left a comment
There was a problem hiding this comment.
LGTM as-is. But I'm not merging this, as it's marked Draft, and fails to pass the build.
@cstamas I would have no problem if you wanted to just "self merge" this (without further review from me) once it passes the build... but perhaps see with @ianopolous if he would also be cool with this, or if we would provide "4 eyes, and no self merges" on this project.
cstamas
commented
Jan 19, 2026
Is left draft on purpose, see comment above: maven and ant use different versions of libs. I don't plan to "self merge", would always like at least one pair of extra eyes. But we need to fix the deps first. |
ianopolous
commented
Jan 19, 2026
Feel free to remove ant in this repo. |
| return new Peer(new MultiAddress(val.apply("Addr")), Cid.decode(val.apply("Peer")), latency, val.apply("Muxer"), val.apply("Streams")); | ||
| String peerId = val.apply("Peer"); | ||
| Multihash peer; // Multihash bug? Throws IAEx Base1 not supported | ||
| try { |
There was a problem hiding this comment.
PeerIds are not Multihashes strictly. They are base58 encoded, without a multibase prefix. Modern ones start with 1. See how we handle it here:
https://github.com/Peergos/Peergos/blob/master/src/peergos/shared/io/ipfs/Cid.java#L148
There was a problem hiding this comment.
Applied fix, pls review
vorburger
commented
Jan 19, 2026
Done in just merged #254. |
manandbytes
commented
Jan 20, 2026
| should be updated as well |
| - "5001:5001" | ||
| user: "ipfs" | ||
| command: [ "daemon", "--enable-pubsub-experiment" ] | ||
| command: [ "daemon", "--enable-pubsub-experiment --enable-namesys-pubsub --routing=dhtclient" ] |
There was a problem hiding this comment.
command is an array, elements in quotes and comma-separated, otherrwise fails with
ipfs-daemon-1 | Error: unknown option "enable-pubsub-experiment --enable-namesys-pubsub --routing"
- command: [ "daemon", "--enable-pubsub-experiment" ]+ command: [ "daemon", "--enable-pubsub-experiment", "--enable-namesys-pubsub", "--routing=dhtclient" ]There was a problem hiding this comment.
Ouch, thanks a ton! Fixed.
| - "5001:5001" | ||
| user: "ipfs" | ||
| command: [ "daemon", "--enable-pubsub-experiment" ] | ||
| command: [ "daemon", "--enable-pubsub-experiment --enable-namesys-pubsub --routing=dhtclient" ] |
There was a problem hiding this comment.
| command: [ "daemon", "--enable-pubsub-experiment--enable-namesys-pubsub--routing=dhtclient" ] | |
| command: [ "daemon", "--enable-pubsub-experiment", "--enable-namesys-pubsub", "--routing=dhtclient" ] |
Uh oh!
There was an error while loading. Please reload this page.
From ancient 0.18.1 to latest 0.39.0. This causes test breakage as some deprecated endpoints like
objectare dropped.