Skip to content

chore: Simplify project by removing the Ant-based build; Maven only is fine - #254

Merged
vorburger merged 1 commit into
ipfs-shipyard:masterfrom
vorburger:rm-ant
Jan 19, 2026
Merged

chore: Simplify project by removing the Ant-based build; Maven only is fine#254
vorburger merged 1 commit into
ipfs-shipyard:masterfrom
vorburger:rm-ant

Conversation

@vorburger

Copy link
Copy Markdown
Collaborator

Triggered by noticing the confusion on #253.

@cstamas I'm sure you're in favour of this... 🤣

@ianopolous would this be cool with you?

CopilotAI review requested due to automatic review settings January 19, 2026 19:25

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the project build system by removing the Ant-based build configuration and retaining only Maven for building and testing. The change removes legacy build infrastructure that was causing confusion, as mentioned in issue #253.

Changes:

  • Removed Ant build configuration file (build.xml)
  • Removed Ant build and test steps from the CI workflow
  • Removed JAR dependencies from the lib/ directory that were used by the Ant build
  • Fixed trailing whitespace in the CI workflow file

Reviewed changes

Copilot reviewed 2 out of 8 changed files in this pull request and generated no comments.

FileDescription
build.xmlComplete removal of the Ant build configuration file
.github/workflows/ant.ymlRemoved Ant build and test steps; retained Maven-based testing
lib/*.jarRemoved JAR dependencies (multibase, multiaddr, multihash, cid, junit, hamcrest) that were managed by Ant

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ianopolous

Copy link
Copy Markdown
Collaborator

Yep totally fine.

@vorburger
vorburger merged commit 8e6f10d into ipfs-shipyard:masterJan 19, 2026
7 checks passed
@odisseus

Copy link
Copy Markdown
Contributor

You should have also updated the readme file, because it still refers to Ant commands. Also, the CI workflow file should probably be renamed.

@odisseusodisseus mentioned this pull request Jan 20, 2026
@@ -22,8 +22,3 @@ jobs:
run: ./install-run-ipfs.sh
- name: Build & run tests with Maven
run: mvn test

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it enable batch mode with -B and run verify instead?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM; see #262.

@vorburger

Copy link
Copy Markdown
CollaboratorAuthor

You should have also updated the readme file, because it still refers to Ant commands. Also, the CI workflow file should probably be renamed.

@odisseus this was done in #255.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@vorburger@ianopolous@odisseus@manandbytes