Uh oh!
There was an error while loading. Please reload this page.
chore: Simplify project by removing the Ant-based build; Maven only is fine - #254
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the project build system by removing the Ant-based build configuration and retaining only Maven for building and testing. The change removes legacy build infrastructure that was causing confusion, as mentioned in issue #253.
Changes:
- Removed Ant build configuration file (
build.xml) - Removed Ant build and test steps from the CI workflow
- Removed JAR dependencies from the
lib/directory that were used by the Ant build - Fixed trailing whitespace in the CI workflow file
Reviewed changes
Copilot reviewed 2 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build.xml | Complete removal of the Ant build configuration file |
| .github/workflows/ant.yml | Removed Ant build and test steps; retained Maven-based testing |
| lib/*.jar | Removed JAR dependencies (multibase, multiaddr, multihash, cid, junit, hamcrest) that were managed by Ant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ianopolous
commented
Jan 19, 2026
Yep totally fine. |
Uh oh!
There was an error while loading. Please reload this page.
odisseus
commented
Jan 20, 2026
You should have also updated the readme file, because it still refers to Ant commands. Also, the CI workflow file should probably be renamed. |
| @@ -22,8 +22,3 @@ jobs: | |||
| run: ./install-run-ipfs.sh | |||
| - name: Build & run tests with Maven | |||
| run: mvn test | |||
There was a problem hiding this comment.
should it enable batch mode with -B and run verify instead?
Triggered by noticing the confusion on #253.
@cstamas I'm sure you're in favour of this... 🤣
@ianopolous would this be cool with you?