Uh oh!
There was an error while loading. Please reload this page.
Conversation
cstamas
commented
Jan 20, 2026
ping @odisseus |
| @@ -18,7 +20,7 @@ jobs: | |||
| with: | |||
| distribution: temurin | |||
| java-version: 11 | |||
There was a problem hiding this comment.
cache: 'maven' would enable caching of Maven artifacts
There was a problem hiding this comment.
The cache: 'maven' would cache local repository, and usually this is not what you want. But I agree, we can use this "low hanging fruit" until come up with better cache.
There was a problem hiding this comment.
The
cache: 'maven'would cache local repository, and usually this is not what you want. But I agree, we can use this "low hanging fruit" until come up with better cache.
Now Maven does not download anything and this is what I want:
Cache hit for: setup-java-Linux-x64-maven-3ddbf759ed683e90355f47106d5267473ecc42a2c13648ab09a57287f5d9dfa9
...
Cache restored successfully
Cache restored from key: setup-java-Linux-x64-maven-3ddbf759ed683e90355f47106d5267473ecc42a2c13648ab09a57287f5d9dfa9
There was a problem hiding this comment.
That's right, with pre-populated local repository it will pick up everything (even corruption) from previous build. This is why caching local repository is wrong.
Maven caching without re-using local repository is much better:
https://maveniverse.eu/blog/2025/09/16/maven-local-repository/
and
https://maveniverse.eu/docs/mimir/
There was a problem hiding this comment.
Or in other words: building with empty local repository AND still downloading nothing is what CI should do, as otherwise it is prone to same issues as your workstation, and leads to issues "works for me (on my workstation)" but fails on my colleagues workstation (and endless scratching heads why).
cstamas
commented
Jan 20, 2026
Thanks @manandbytes and @odisseus for helping! |
ianopolous
commented
Jan 20, 2026
Is there a way to include hashes in the pom for dependencies so we are not vulnerable to third party tampering? |
cstamas
commented
Jan 20, 2026
Yes, not in the pom but it is possible to lock down key deps. |
ianopolous
commented
Jan 20, 2026
That was a large factor of why I had vendored dependencies. To rule out a class of supply chain attack. |
cstamas
commented
Jan 20, 2026
Let's go baby steps :) |
Removal of Ant left some remnants, clean them up.