Uh oh!
There was an error while loading. Please reload this page.
[#519] correct regression with server_verify_mode of "none" - #530
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
korydraughn
left a comment
There was a problem hiding this comment.
Seems good. Has this been tested?
These changes were tested pre-review but not yet post-review. Likely I'll wait until after we've reviewed a few more PR's as a team and I've tested the changes all together, then we'll merge them all at once. That is just the more efficient way to do it at the moment, given the changes to the testing process that are in store for PRC v2.1.0 |
korydraughn
commented
Apr 10, 2024
That sounds more error prone since you're handling multiple PRs, but if you feel that's the most efficient way to handle it on your end, then proceed. |
I felt it was the most efficient, if not overall best, way. But I don't think it adds any extra opportunity for error, any more than the requisite Git mechanics. |
d-w-moore
commented
Apr 16, 2024
Changing commit message to exclude #281 in head-line per #508 (comment) |
Tested and passing. To resolve "critical" codacy comment (re unexpected parameter |
korydraughn
commented
Apr 22, 2024
Squash to taste if ready, no pounds. We'll hold on merging this one until #527 is merged. |
… explicitly none Fixes a regression on issue irods#281.
No description provided.