Skip to content

[#502] experimental test harness using a single container - #508

Closed
d-w-moore wants to merge 13 commits into
irods:mainfrom
d-w-moore:502.m
Closed

[#502] experimental test harness using a single container#508
d-w-moore wants to merge 13 commits into
irods:mainfrom
d-w-moore:502.m

Conversation

@d-w-moore

@d-w-moored-w-moore commented Jan 30, 2024

Copy link
Copy Markdown
Collaborator

Automatic launch of specific test scripts in their own container.

@d-w-moore
d-w-moore marked this pull request as draft January 30, 2024 16:11
d-w-moore
d-w-moore commented Jan 30, 2024
View reviewed changes
Comment threadirods/test/harness/000_install-irods.Dockerfile Outdated
korydraughn
korydraughn reviewed Jan 30, 2024
View reviewed changes

@korydraughnkorydraughn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain what this PR does?

Are there plans to leverage the consortium test hook and the testing environment?

Comment threadirods/test/harness/000_install-irods.Dockerfile Outdated
Comment threadirods/test/harness/tests/repo Outdated
Comment threadirods/test/harness/000_install-irods.Dockerfile Outdated
@d-w-moore

d-w-moore commented Jan 30, 2024•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Please explain what this PR does?

Are there plans to leverage the consortium test hook and the testing environment?

[....] I wanted to get a start on this issue and get comments in but do not believe this will be merged for the next prc release.

Seems this PR is part of the 2.0.0 milestone after all, so maybe we try to leverage those somewhere in a later release?

@d-w-moore
d-w-mooreforce-pushed the 502.m branch 2 times, most recently from fedbf73 to 858374bCompareMarch 7, 2024 11:05
@d-w-moore

d-w-moore commented Mar 8, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Rebasing atop 518.m , and I may leave it that way to save time. After un-drafting, we'll decide if #518 gets its own pull request

@d-w-moore
d-w-mooreforce-pushed the 502.m branch 3 times, most recently from 8109fec to 00e9cc2CompareMarch 14, 2024 12:21
@trel

trel commented Mar 14, 2024

Copy link
Copy Markdown
Member

let's not mention 281 in the first part of the commit lines, we can reference it in the body if helpful/needed.

@d-w-moore

d-w-moore commented Mar 14, 2024

Copy link
Copy Markdown
CollaboratorAuthor

let's not mention 281 in the first part of the commit lines, we can reference it in the body if helpful/needed.

Yes, will correct that.

@d-w-moore
d-w-mooreforce-pushed the 502.m branch 2 times, most recently from 2d19eac to bc07343CompareMarch 24, 2024 08:36
@d-w-moore
d-w-mooreforce-pushed the 502.m branch 2 times, most recently from 65a4bee to a9c2d75CompareApril 5, 2024 09:04
@d-w-moored-w-moore mentioned this pull request Apr 16, 2024
Merged
@d-w-moored-w-moore changed the title [_502] experimental test harness using containers[#502] experimental test harness using containersMay 14, 2024
@d-w-moore

d-w-moore commented May 14, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Please explain what this PR does?

Are there plans to leverage the consortium test hook and the testing environment?

Basically there are a bunch of tests which demand unique setup or otherwise unique running conditions. This PR is part of a plan to run each of those - automatically is the hope. Inclusion is the idea, preventing regression. And it's easy to set up conditions for such tests within a Dockerfile.

@d-w-moored-w-moore mentioned this pull request May 14, 2024
Merged
@d-w-moored-w-moore changed the title [#502] experimental test harness using containers[#502] experimental test harness using a single containerJun 14, 2024
@d-w-moored-w-moore mentioned this pull request Oct 2, 2024
Merged
@d-w-moored-w-moore mentioned this pull request Mar 11, 2025
Merged
@d-w-moore

d-w-moore commented Mar 14, 2025•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

SKIP_IINIT_FOR_PASSWORD documented (currently in 7d75ae9)

@d-w-moore
d-w-mooreforce-pushed the 502.m branch 2 times, most recently from 7d75ae9 to b4f6592CompareMarch 15, 2025 01:23
@d-w-moore
[_502] experimental test harness using containers
3f959d9
testuser universal for all containers
login_auth*.py adjustments
[__502] scriptdir
[__502] patch for consistency in starting
document SKIP_IINIT_FOR_PASSWORD
"funcs" include file renamed to "test_support_functions"
remove fail.sh to scripts dir
@d-w-moore
extra time parameter to age_out_pam_password
1a6ce64
@d-w-moore

d-w-moore commented Sep 23, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Once all the conversations above are resolved, my plan is to cancel this PR and integrate the changes herein (the addition of a single-docker-container test harness that is well suited for testing via BATS scripts and other test modules requiring custom setup) into a new Pull Request dealing with the wider goal of testing PRC under Github Actions.

@trel

trel commented Sep 23, 2025

Copy link
Copy Markdown
Member

or you can just push the changes here - so the conversation is in one place?

up to you.

of course, link back here in any new PR so the archaeologists can find it.

@d-w-moore

d-w-moore commented Feb 17, 2026

Copy link
Copy Markdown
CollaboratorAuthor

we can close this, as the work has been merged.

@korydraughn

korydraughn commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

@d-w-moore has stated that this PR is no longer needed.

It is superseded by work for #772.

Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@korydraughnkorydraughnkorydraughn left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d-w-moore@trel@korydraughn