F.prototype by flaviohblima · Pull Request #231 · javascript-tutorial/pt.javascript.info

flaviohblima · 2021-10-25T02:55:05Z

No description provided.

odsantos

Here is a review.

Two files in the "1-js/08-prototypes/02-function-prototype/4-new-object-same-constructor" folder seem not yet translated.

Please, feel free to comment where you might disagree.

Thank you,
Osvaldo.

javascript-translate-bot · 2021-10-26T20:34:50Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

flaviohblima · 2021-10-28T16:41:49Z

/done

flaviohblima · 2021-10-29T20:14:11Z

Hello @odsantos ,

I missed some of your reviews in my last reading. Sorry.

Now I think I resolved everything.

I did not resolve this one, because I do not use the "de" like this.

If its ok for you, I believe now its done.

Thank you for your reviews!
Flávio

odsantos · 2021-10-29T20:28:42Z

Hello @flaviohblima ,
Thank you for your message.

I hope to check it as soon as possible. Probably, within a few days.

However, I still see my review notes. I believe I shouldn't if they were resolved and committed.
But it might be all right, as well.

Osvaldo.

odsantos

Hello @flaviohblima ,

Here is another review.

Thank you,
Osvaldo.

javascript-translate-bot · 2021-10-31T22:52:35Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

…structor/solution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

flaviohblima · 2021-11-01T16:44:33Z

/done

odsantos

Hello @flaviohblima ,

I reopened a conversation and I still am insisting on that one with 'de'.
Would you mind if I ask you to review it again?
Please, I continue open to your appreciation of my review.

Thank you,
Osvaldo.

javascript-translate-bot · 2021-11-19T20:53:28Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

flaviohblima · 2021-11-24T14:37:19Z

Hello @odsantos ,

If you insist, I see no problem fixing it. I already commited the change.

Thank you,
Flávio

flaviohblima · 2021-11-24T14:37:31Z

/done

odsantos

Hello @flaviohblima ,

I appreciate the patience you had.
By the rules, we need a second reviewer for your work to be merged.

Let's hope that either @luizclr, @Mr-Saxobeat, @adriavieira314, or @kiniggit have time for that.

Best regards,
Osvaldo.

CLAassistant · 2022-04-29T09:27:35Z

All committers have signed the CLA.

jonnathan-ls

@flaviohblima

I recorded some notes

Note: the images (SVG) have not been translated.

I didn't add the above note in the review, but I was wondering if you could perform the script translation procedure? As per image translation guidance at https://github.com/javascript-tutorial/server#translating-images

If not, no problem, I perform the procedure separately in another Pull Request.

javascript-translate-bot · 2022-07-06T04:36:01Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

…he PR#231 Pull Request: #231

jonnathan-ls · 2023-09-18T01:27:19Z

/done

jonnathan-ls · 2023-09-18T01:28:21Z

jonnathan-ls requested changes on behalf of https://github.com/orgs/javascript-tutorial/teams/translate-pt on Jul 6, 2022

I applied the corrections I requested by contributing to the PR to be able to accept the request

javascript-translate-bot · 2023-09-18T01:34:12Z

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

FEAT: Translate F.prototype article, task and solution to pt.
2f6340c

javascript-translate-bot added the review needed label Oct 25, 2021

javascript-translate-bot requested a review from a teamOctober 25, 2021 02:55

javascript-translate-bot mentioned this pull request Oct 25, 2021
Portuguese Translation Progress #1
Open

odsantos requested changes Oct 26, 2021
View reviewed changes

javascript-translate-bot removed the review needed label Oct 26, 2021

javascript-translate-bot added the changes requested label Oct 26, 2021

FIX: article/tasks reviews resolved. Translate missing task.
6ed9576

javascript-translate-bot added review needed and removed changes requested labels Oct 28, 2021

javascript-translate-bot requested a review from a teamOctober 28, 2021 16:41

FIX: Resolving reviews.
75ce566

odsantos requested changes Oct 31, 2021
View reviewed changes

javascript-translate-bot removed the review needed label Oct 31, 2021

javascript-translate-bot added the changes requested label Oct 31, 2021

flaviohblimaand others added 5 commits November 1, 2021 13:40

Update 1-js/08-prototypes/02-function-prototype/4-new-object-same-con…
74f456d
…structor/solution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

Update 1-js/08-prototypes/02-function-prototype/4-new-object-same-con…
fa0c64e
…structor/solution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

Update 1-js/08-prototypes/02-function-prototype/4-new-object-same-con…
4d86e7c
…structor/solution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

Update 1-js/08-prototypes/02-function-prototype/4-new-object-same-con…
525cc2e
…structor/solution.md Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

Update 1-js/08-prototypes/02-function-prototype/article.md
2157dd4
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

javascript-translate-bot added review needed and removed changes requested labels Nov 1, 2021

javascript-translate-bot requested a review from a teamNovember 1, 2021 16:44

odsantos requested changes Nov 19, 2021
View reviewed changes

Comment thread1-js/08-prototypes/02-function-prototype/article.md Outdated

javascript-translate-bot removed the review needed label Nov 19, 2021

javascript-translate-bot added the changes requested label Nov 19, 2021

Update 1-js/08-prototypes/02-function-prototype/article.md
7054535
Co-authored-by: Osvaldo Dias dos Santos <vadodsantos@yahoo.com>

javascript-translate-bot added review needed and removed changes requested labels Nov 24, 2021

javascript-translate-bot requested a review from a teamNovember 24, 2021 14:37

odsantos approved these changes Nov 28, 2021
View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels Nov 28, 2021

jonnathan-ls requested changes Jul 6, 2022
View reviewed changes

javascript-translate-bot added the changes requested label Jul 6, 2022

jonnathan-ls added 2 commits September 17, 2023 22:22

refactor: applies the corrections requested in the second review of t…
e159873
…he PR#231 Pull Request: #231

refactor: translates pending texts in svg files
2e32549

jonnathan-ls approved these changes Sep 18, 2023
View reviewed changes

javascript-translate-bot removed the changes requested label Sep 18, 2023

jonnathan-ls merged commit b569358 into javascript-tutorial:masterSep 18, 2023

jonnathan-ls removed the needs +1 label Sep 18, 2023

Uh oh!

Uh oh!

Conversation

flaviohblima commented Oct 25, 2021

Uh oh!

odsantos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 26, 2021

Uh oh!

flaviohblima commented Oct 28, 2021

Uh oh!

flaviohblima commented Oct 29, 2021

Uh oh!

odsantos commented Oct 29, 2021

Uh oh!

odsantos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 31, 2021

Uh oh!

flaviohblima commented Nov 1, 2021

Uh oh!

odsantos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javascript-translate-bot commented Nov 19, 2021

Uh oh!

flaviohblima commented Nov 24, 2021

Uh oh!

flaviohblima commented Nov 24, 2021

Uh oh!

odsantos left a comment

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented Apr 29, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonnathan-ls left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 6, 2022

Uh oh!

jonnathan-ls commented Sep 18, 2023

Uh oh!

jonnathan-ls commented Sep 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

CLAassistant commented Apr 29, 2022•
edited
Loading

jonnathan-ls left a comment •
edited
Loading

jonnathan-ls commented Sep 18, 2023•
edited
Loading