Uh oh!
There was an error while loading. Please reload this page.
Hotfix/crumbissuer - #110
Conversation
hamaron
commented
Nov 3, 2015
PR for #38 |
ojacquemart
commented
Nov 3, 2015
👍 It's maybe not a good practice to use e.printStackTrace? |
hamaron
commented
Nov 3, 2015
@ojacquemart Thanks for the comment! I checked the use of |
ojacquemart
commented
Nov 3, 2015
It's ok if it |
pnathan
commented
Nov 4, 2015
Speaking as an occasional user, why wouldn't we want |
ojacquemart
commented
Nov 6, 2015
By using a logging framework, you can log in different levels (trace, debug, info, warn, error, ...). Also, you can choose your output: file, console, ... and you can keep consistency in your logs format and so on. All that is often configurable through a file. By the way, the PR is great and I am waiting for a merge :) |
hamaron
commented
Nov 6, 2015
Yup, I've been waiting for getting this PR merged for more than a year ;) |
khmarbaise
commented
Nov 7, 2015
First thanks for the PR, but can you please squash the commits... |
ojacquemart
commented
Nov 17, 2015
ping @hamaron :) |
hamaron
commented
Nov 17, 2015
@ojacquemart Oops! I created another PR: #116 :) |
No description provided.