Uh oh!
There was an error while loading. Please reload this page.
#39: Don't propagate IOException when GET for /CrumbIssuer fails. - #39
#39: Don't propagate IOException when GET for /CrumbIssuer fails.#39hamaron wants to merge 1 commit into
Conversation
cosmin
commented
Jan 20, 2015
this no longer merges cleanly |
hamaron
commented
Jan 21, 2015
Hi, cosmin! Thank you! :) |
zjs
commented
Sep 21, 2015
What's the status of this? Do we just need an updated version of this patch? |
khmarbaise
commented
Sep 28, 2015
Would you please so kind and rebase this PR to the current state of the master code and squash if not already done. Thanks for your support. |
ojacquemart
commented
Nov 2, 2015
The javadoc says that the getQuietly logs the error and does not propagate the IOException but it throws an Assertion error. Should the method just log the IOException & return a null value instead? I could submit a new PR if anyone is interested. I had to make this change to use the library in a project. |
hamaron
commented
Nov 3, 2015
Oh sorry that I didn't realize I had your comments. |
hamaron
commented
Nov 3, 2015
I will create another PR, hence this PR was closed. |
hamaron
commented
Nov 3, 2015
Created a new PR #110. |
#39: Don't propagate IOException when GET for /CrumbIssuer fails.
No description provided.