FIX Fix OpenBLAS detection for conda package on Windows - #240
Merged
ogrisel merged 14 commits intoSep 8, 2026
Conversation
ogrisel
reviewed
Sep 8, 2026
ogrisel
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix but the new test will fail if numpy and scipy use atlas, mkl, blis...
| info = threadpool_info_from_subprocess(module) | ||
|
|
||
| blas_info = select(info, internal_api="openblas") | ||
| assert len(blas_info) > 0 |
Contributor
There was a problem hiding this comment.
We should inspect the output of pip freeze and/or conda list to set expectations on the presence of openblas.
Member
Author
I tweaked the test to check that any BLAS implementation is detected. Not sure if you want a more thorough test comparing the |
ogrisel
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #231
So OpenBLAS from conda use
openblas.dll, which probably means we never detected OpenBLAS conda package? pip on Windows does uselibscipy_openblasprefix.