-
Notifications
You must be signed in to change notification settings - Fork 36
FIX Fix OpenBLAS detection for conda package on Windows #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ogrisel
merged 14 commits into
joblib:master
from
lesteve:fix-conda-openblas-detection-windows
Sep 8, 2026
+42
−0
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e5bfb4b
FIX Fix OpenBLAS detection for conda package on Windows
lesteve 81439fd
Add changelog
lesteve 20af1a2
fix test to be generic with any BLAS implementation
lesteve 1006a4e
black
lesteve 8490a53
Fix atlas on CI
lesteve 2b0bdc0
black
lesteve d5f3ddd
Skip if numpy/scipy are not installed
lesteve ab737d3
Make test conda-specific to simplify things
lesteve 0327472
black
lesteve c193629
Tweak test
lesteve ea1648e
Fix windows
lesteve c8a6661
Fix test
lesteve b87cd27
black
lesteve c863990
Ignore flexiblas in the new test
ogrisel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should inspect the output of pip freeze and/or conda list to set expectations on the presence of openblas.