Uh oh!
There was an error while loading. Please reload this page.
Add a test for "index.md" frontmatter and fix the repo to match - #2377
Conversation
evankanderson
commented
Apr 9, 2020
Here is a script which does not work for some cases which I used to start the conversion (just for reference): #!/bin/bashecho Working on $1
INDEX="${1%README.md}index.md"
awk '/^---/, /^$/'"$1">"$INDEX"echo'{{% readfile file="README.md" %}}'>>"$INDEX"
awk '/^---/, /^$/ {next}; {print}'"$1">"$1.tmp"&& mv "$1.tmp""$1"echo Wrote $INDEX and $1 |
evankanderson
commented
Apr 9, 2020
Verified |
evankanderson
commented
Apr 9, 2020
The test failure is fixed by knative/test-infra#1898 |
evankanderson
commented
Apr 10, 2020
/retest pull-knative-docs-integration-tests |
evankanderson
commented
Apr 10, 2020
/hold I just found some odd rendering that I need to investigate. |
evankanderson
commented
Apr 13, 2020
Example: https://docs-2377.default.docs-on-the-rocks.io/community/samples/serving/helloworld-haskell/ has lost the sidebar. |
evankanderson
commented
Apr 15, 2020
/hold cancel |
evankanderson
commented
Apr 15, 2020
/retest |
evankanderson
commented
Apr 15, 2020
The rendering works with knative/website#161 merged and applied on the website side. I'll still need to update the other branches after this before we can drop the |
abrennan89
commented
May 15, 2020
/lgtm |
knative-prow-robot
commented
May 15, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hugo expects page bundles to have an
_index.mdorindex.mdfile, but GitHub expectsREADME.md. Until gohugoio/hugo#4691 is fixed (still in flight, negotiating with hugo owner), it seems simplest to simply createindex.mdfiles for these leaf bundles with appropriate frontmatter and a{{% readfile file="README.md" %}}shortcode.Proposed Changes
index.mdfiles._index.htmlfrontpage that is in the website, so that we can eventually stop copying the file during website build.