Skip to content
This repository was archived by the owner on Dec 15, 2021. It is now read-only.

Don't move 'README.md' over 'index.md', either - #161

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
evankanderson:in-dex
Apr 15, 2020
Merged

Don't move 'README.md' over 'index.md', either#161
knative-prow-robot merged 1 commit into
knative:masterfrom
evankanderson:in-dex

Conversation

@evankanderson

@evankandersonevankanderson commented Apr 15, 2020

Copy link
Copy Markdown
Member

This is needed for knative/docs#2377 to render correctly -- otherwise it overwrites the index.md files with the README.md files without appropriate frontmatter.

@googlebotgooglebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 15, 2020
@knative-prow-robotknative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2020
@evankanderson

evankanderson commented Apr 15, 2020

Copy link
Copy Markdown
MemberAuthor

/assign @n3wscott , since we don't really have a maintainer here. :-/

n3wscott
n3wscott approved these changes Apr 15, 2020
View reviewed changes

@n3wscottn3wscott left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robotknative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020
@knative-prow-robot

knative-prow-robot commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot
knative-prow-robot merged commit 1e0a03e into knative:masterApr 15, 2020
This was referenced Apr 15, 2020
Merged
Open
@evankanderson
evankanderson deleted the in-dex branch March 23, 2021 23:25
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@carieshmariecarieshmarieAwaiting requested review from carieshmarie
@samodellsamodellAwaiting requested review from samodell
1 more reviewer
@n3wscottn3wscottn3wscott approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@n3wscottn3wscott

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cla: yesIndicates the PR's author has signed the CLA.lgtmIndicates that a PR is ready to be merged.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evankanderson@knative-prow-robot@n3wscott@googlebot