Skip to content

vector_sum_of_squares should only rescale for floating-point types, and should not use Scalar(1.0) or Scalar(0.0) otherwise #144

Description

@mhoemmen

vector_sum_of_squares has the following issues:

  1. It does rescaling for all types, not just floating-point types (and complex-of-floating-point types).
  2. It attempts to construct Scalar(1.0) and Scalar(0.0) for all types.

See discussion here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions