Fix hermitian_matrix_rank_1_update - #264
Merged
Merged
Conversation
Add a test that exercises both the with-alpha and without-alpha overloads; it passes.
This was referenced Jan 16, 2024
dalg24
approved these changes
Apr 3, 2024
dalg24
left a comment
Member
There was a problem hiding this comment.
Not a thorough review but I have no objection and this has been sitting for too long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ambiguous overloads of
hermitian_matrix_rank_1_update. Add unit test.Fixes #138.
Fixes #156.