Fix the build; make layout_transpose and conjugated_accessor conform - #269
Conversation
dalg24
left a comment
There was a problem hiding this comment.
I scrolled through the changes of the last 3 commits (that is excluding the changes from the PR that I just merged) and it looks good besides https://github.com/kokkos/stdBLAS/pull/269/files/2584d02d3230805525db529d39033982c3120fc2..ca3f2614dfa5d6edb2abb7bdcbc508d90a56eeef#r1550159723
If you withdraw these addition I will approve and merge
layout_transpose was imitating an old version of mdspan. For example, it used size_type instead of index_type as the return type of operator(). That made tests for the return type of transposed fail (because the transposed layout mapping's extents_type had the wrong index_type). This commit fixes that. Fix transposed(layout_stride) build warning. Add tests for transposed of layout_right and transposed of layout_stride.
Namespaces: The tests (in tests/native) and examples no longer assume that linalg and mdspan live in the std::experimental namespace. Includes: This implies including mdspan/mdspan.hpp instead of experimental/mdspan.hpp.
and otherwise bring it in line with the Standard. Add conjugated test for a nonarithmetic real type. "Real type" in this case just means that conj of it is not ADL-findable. Add conjugated test for a custom complex number. "Custom complex number" in this case just means that conj of it is ADL-findable.
ca3f261 to
735ff98
Compare
|
@dalg24 wrote:
Fixing the merge conflicts seems to have made this link invalid. My understanding is that you were referring to the new tests in tests/native/transposed.cpp. Those tests only exercise current P1673R13 features. As I explained above,
That has always been true; this has nothing to do with any new proposals. |
This fixes the build, which is currently broken, thus blocking any new features.
Change this repository so that it no longer uses or depends on
std::experimental.Fix
layout_transposeto conform with the Standard. It had implemented an older version ofmdspanthat usedsize_typeinstead ofindex_type.Rename
accessor_conjugatetoconjugated_accessorand otherwise bring it in line with the Standard. Improve tests forconjugated.This is rebased atop #264 which I submitted in January but hasn't yet been merged. Please either merge that one first, or close that one and merge this one.