Uh oh!
There was an error while loading. Please reload this page.
hipopotam - #9
Merged
Merged
Conversation
Update Code-Dump with the limelight implementation from main.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThe PR updates Limelight turret correction, adds V3.6 recording and replay velocity support, changes replay control behavior, adds fixed-pose OpModes, and adjusts manual control mappings. ChangesKronbot control and replay
Estimated code review effort: 4 (Complex) | ~45 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant FinalRecorderOp
participant Pinpoint
participant Limelight
participant CSVFile
FinalRecorderOp->>Pinpoint: sample translational and angular velocity
FinalRecorderOp->>Limelight: switch target pipeline
FinalRecorderOp->>CSVFile: write V3.6 recording frame
CSVFile->>FinalReplayOp: provide recorded pose, voltage, and velocity data
FinalReplayOp->>Limelight: enable live turret aiming
FinalReplayOp->>Pinpoint: sample playback velocity
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before issuing a pull request, please see the contributing page.
Summary by CodeRabbit