Skip to content
This repository was archived by the owner on Mar 13, 2022. It is now read-only.

Drop Python3.4 - #127

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
oz123:drop-python-34
Jul 8, 2019
Merged

Drop Python3.4#127
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
oz123:drop-python-34

Conversation

@oz123

@oz123oz123 commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

Python 3.4 has become EOL on March 18, 2019.

https://www.python.org/dev/peps/pep-0429/

@k8s-ci-robotk8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2019
@oz123oz123 mentioned this pull request Apr 5, 2019
Merged
@codecov-io

codecov-io commented Apr 5, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #127 +/- ##
=======================================
Coverage 92.84% 92.84% =======================================
Files 13 13 Lines 1328 1328 =======================================
Hits 1233 1233 Misses 95 95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c03b3b...511243a. Read the comment docs.

@oz123
Drop Python3.4
511243a
 Python 3.4 has become EOL on March 18, 2019.
https://www.python.org/dev/peps/pep-0429/
@yliaog

yliaog commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

3.4.10 final: March 18, 2019

the last release was 3/18/2019.
I think it's better to wait for a bit longer before dropping it.

@micw523

micw523 commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

/hold
Let's keep this open and merge this after a few months then.

@k8s-ci-robotk8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
@fejta-bot

fejta-bot commented Jul 4, 2019

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robotk8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2019
@oz123

oz123 commented Jul 4, 2019

Copy link
Copy Markdown
ContributorAuthor

@yliaog can this be moved forward. It's not a good service for the community to support python3.4.

@yliaog

yliaog commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

@micw523 what do you think?

@micw523

micw523 commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

@yliaog It's probably fine. I see Matplotlib has already dropped Python 3.4.
/cc @roycaihw

@yliaog

yliaog commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

@micw523 sounds good to me. could you please cancel the hold then?

@micw523

micw523 commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

/hold cancel

@k8s-ci-robotk8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2019
@yliaog

yliaog commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robotk8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@k8s-ci-robot

k8s-ci-robot commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oz123, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@k8s-ci-robot
k8s-ci-robot merged commit 8b748a7 into kubernetes-client:masterJul 8, 2019
@oz123
oz123 deleted the drop-python-34 branch October 2, 2019 18:37
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw
@yliaogyliaogAwaiting requested review from yliaog

Assignees

@yliaogyliaog

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtmIndicates that a PR is ready to be merged.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oz123@codecov-io@yliaog@micw523@fejta-bot@k8s-ci-robot