Skip to content

Drop Python3.4 - #807

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
oz123:drop-python-34
Jul 9, 2019
Merged

Drop Python3.4#807
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
oz123:drop-python-34

Conversation

@oz123

@oz123oz123 commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

@k8s-ci-robotk8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2019
micw523
micw523 reviewed Apr 5, 2019
View reviewed changes

@micw523micw523 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also drop python 3.4 from .travis.yml.
@roycaihw, do we want to drop Python 3.4 from PyPI as well?

@oz123
Drop Python3.4
e8fd4b9
 Python3.4 become EOL on 2019.03.18.
https://www.python.org/dev/peps/pep-0429/
@micw523

micw523 commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

/hold

@k8s-ci-robotk8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
@fejta-bot

fejta-bot commented Jul 4, 2019

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robotk8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2019
@micw523

micw523 commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

/hold cancel

@k8s-ci-robotk8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2019
@micw523

micw523 commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

/remove-lifecycle stale

@k8s-ci-robotk8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 8, 2019
@roycaihw

roycaihw commented Jul 9, 2019

Copy link
Copy Markdown
Member

/lgtm
/approve

ref kubernetes-client/python-base#127

@k8s-ci-robotk8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2019
@k8s-ci-robot

k8s-ci-robot commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oz123, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@k8s-ci-robot
k8s-ci-robot merged commit da8c843 into kubernetes-client:masterJul 9, 2019
@oz123oz123 mentioned this pull request Jul 25, 2019
Merged
@scottileescottilee mentioned this pull request Jul 26, 2019
Closed
@oz123oz123 mentioned this pull request Aug 14, 2019
Closed
6 tasks
@roycaihwroycaihw mentioned this pull request Feb 21, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lavalamplavalampAwaiting requested review from lavalamp
@roycaihwroycaihwAwaiting requested review from roycaihw
1 more reviewer
@micw523micw523micw523 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@roycaihwroycaihw

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtm"Looks good to me", indicates that a PR is ready to be merged.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oz123@micw523@fejta-bot@roycaihw@k8s-ci-robot