Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 13, 2022. It is now read-only.
Merging configs with missing fields - #163
Merged
k8s-ci-robot merged 2 commits intoSep 24, 2019
Merged
Conversation
goddenrich
commented
Sep 23, 2019
ContributorAuthor
/assign @roycaihw |
goddenrich
commented
Sep 23, 2019
ContributorAuthor
I think the failing tests are unrelated to this change |
steakunderscore
approved these changes
Sep 23, 2019
roycaihw
commented
Sep 23, 2019
Member
test failure tracked in kubernetes-client/python#963 /cc @tomplus |
roycaihw
commented
Sep 24, 2019
Member
/lgtm |
k8s-ci-robot
commented
Sep 24, 2019
Contributor
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: goddenrich, roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses issue #162