Skip to content

support false values and missing fields in configs - #969

Merged
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
goddenrich:support-false-and-missing-fields-config
Sep 25, 2019
Merged

support false values and missing fields in configs#969
k8s-ci-robot merged 1 commit into
kubernetes-client:masterfrom
goddenrich:support-false-and-missing-fields-config

Conversation

@goddenrich

Copy link
Copy Markdown
Contributor

updated the python-base to include support for false values and missing fields in config files

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robotk8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 25, 2019
@k8s-ci-robotk8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 25, 2019
@k8s-ci-robotk8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 25, 2019
@goddenrich

Copy link
Copy Markdown
ContributorAuthor

/assign @yliaog

@micw523

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robotk8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2019
@micw523

Copy link
Copy Markdown
Contributor

@yliaog

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goddenrich, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2019
@k8s-ci-robot
k8s-ci-robot merged commit 2b3fe30 into kubernetes-client:masterSep 25, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.lgtm"Looks good to me", indicates that a PR is ready to be merged.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@goddenrich@k8s-ci-robot@micw523@yliaog