[operations] Cross-reference drifted dashboard JSON files in latency runbook - #6892
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
…cy runbook Adds a note to runbooks/api-error-rate-latency.md pointing out that cluster-objects/dashboard.json and cluster-objects/dashboard-docs-api.json visualize the same metrics as grafana-dashboard.json but with drifted titles, panel layouts, and error definitions (5xx-only vs 4xx+5xx). Cross-references the tracked finding in #6891. No dashboard JSON, alert threshold, or workflow file is changed. Signed-off-by: kubestellar-hive[bot] <223556219+Copilot@users.noreply.github.com>
|
Important Held for human sign-off on the direction, not on the code. This PR's only tracked rationale is #6891, which the hive filed itself — issue #6891 was filed by kubestellar-hive[bot] and no human has acknowledged it. An agent-filed issue does not, on its own, establish that anyone agreed to the direction (hivecommons/hive#5117). The change may well be right; nothing here is a review of it. To release the hold, acknowledge the direction on that issue — comment on it, assign yourself, or add the |
✅ Deploy Preview for kubestellar-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kubestellar-hive[bot]. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hold released: self-authorization hold disabled by config (#5117) |
What
Adds a cross-reference note to
runbooks/api-error-rate-latency.mdpointing out that
cluster-objects/dashboard.jsonandcluster-objects/dashboard-docs-api.jsonvisualize the samedocs_api_requests_total/docs_api_request_duration_secondsmetricsas
cluster-objects/grafana-dashboard.json(already referenced in thisrunbook), but with drifted titles, panel layouts, and — for the error
panel — a different definition of "error" (5xx-only vs. 4xx+5xx).
This mirrors the existing cross-reference this same runbook already has
for the three drifted
PrometheusRulemanifests (see the "Two otherPrometheusRulemanifests..." paragraph a few lines above, added for#6884).
Why
Confirmed finding: see #6891. An on-call engineer who opens whichever
dashboard they have bookmarked during a
DocsApiHighRequestLatencyorDocsApiHighErrorRatepage gets a different error-rate definition andaggregation than what the alert evaluated, which is actively misleading
rather than merely redundant. Only
grafana-dashboard.jsonhas ascrape-target-up panel matching
DocsApiMetricsTargetDown.Scope
runbooks/api-error-rate-latency.md).PrometheusRulealert threshold or.github/workflows/*file.policy, that decision (which dashboard is actually imported into a
live Grafana instance) is left to a maintainer, tracked in [operations] Three drifted Grafana dashboard JSON files (dashboard.json, dashboard-docs-api.json, grafana-dashboard.json) disagree on error definition and granularity #6891.
Closes/refs: #6891
— hive: agent=operations backend=copilot model=claude-sonnet-4-6