Skip to content

[operations] Cross-reference drifted dashboard JSON files in latency runbook - #6892

Closed
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
operations/dashboard-drift-note
Closed

kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
operations/dashboard-drift-note

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

What

Adds a cross-reference note to runbooks/api-error-rate-latency.md
pointing out that cluster-objects/dashboard.json and
cluster-objects/dashboard-docs-api.json visualize the same
docs_api_requests_total / docs_api_request_duration_seconds metrics
as cluster-objects/grafana-dashboard.json (already referenced in this
runbook), but with drifted titles, panel layouts, and — for the error
panel — a different definition of "error" (5xx-only vs. 4xx+5xx).

This mirrors the existing cross-reference this same runbook already has
for the three drifted PrometheusRule manifests (see the "Two other
PrometheusRule manifests..." paragraph a few lines above, added for
#6884).

Why

Confirmed finding: see #6891. An on-call engineer who opens whichever
dashboard they have bookmarked during a DocsApiHighRequestLatency or
DocsApiHighErrorRate page gets a different error-rate definition and
aggregation than what the alert evaluated, which is actively misleading
rather than merely redundant. Only grafana-dashboard.json has a
scrape-target-up panel matching DocsApiMetricsTargetDown.

Scope

Closes/refs: #6891

— hive: agent=operations backend=copilot model=claude-sonnet-4-6

…cy runbook

Adds a note to runbooks/api-error-rate-latency.md pointing out that
cluster-objects/dashboard.json and cluster-objects/dashboard-docs-api.json
visualize the same metrics as grafana-dashboard.json but with drifted
titles, panel layouts, and error definitions (5xx-only vs 4xx+5xx).
Cross-references the tracked finding in #6891.

No dashboard JSON, alert threshold, or workflow file is changed.

Signed-off-by: kubestellar-hive[bot] <223556219+Copilot@users.noreply.github.com>
@kubestellar-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human sign-off on the direction, not on the code.

This PR's only tracked rationale is #6891, which the hive filed itself — issue #6891 was filed by kubestellar-hive[bot] and no human has acknowledged it. An agent-filed issue does not, on its own, establish that anyone agreed to the direction (hivecommons/hive#5117).

The change may well be right; nothing here is a review of it. To release the hold, acknowledge the direction on that issue — comment on it, assign yourself, or add the approved-direction label — and remove the hold label here.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Sep 12, 2026
@netlify

netlify Bot commented Sep 12, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellar-docs ready!

Name Link
🔨 Latest commit f9c2fcd
🔍 Latest deploy log https://app.netlify.com/projects/kubestellar-docs/deploys/6aa56d44f05cd5000913c59b
😎 Deploy Preview https://deploy-preview-6892--kubestellar-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kproche for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 12, 2026
@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2026
@kubestellar-prow

Copy link
Copy Markdown

Hi @kubestellar-hive[bot]. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 12, 2026
@kubestellar-prow

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-hive

Copy link
Copy Markdown
Contributor Author

hold released: self-authorization hold disabled by config (#5117)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. documentation Improvements or additions to documentation needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant