[operations] ops: cross-reference dashboard drift and add contributor-profiles runbook - #6936
Conversation
…book - runbooks/api-error-rate-latency.md: add a cross-reference paragraph noting dashboard.json, dashboard-docs-api.json, and grafana-dashboard.json visualize the same metrics but disagree on error definition (5xx-only vs 4xx+5xx) and aggregation granularity, mirroring the existing PrometheusRule drift cross-reference in the same runbook (refs #6891, #6928). - runbooks/contributor-profiles-failure-monitoring.md: new runbook documenting the silent-failure gap in generate-leaderboard.yml's 'Generate contributor profiles' step (continue-on-error: true hides its failures from the workflow's own if: failure() alert step), with manual detection and recovery steps (refs #6899). - runbooks/README.md: index the new runbook. Documentation only; no workflow file is touched, and the underlying code gaps in #6891/#6899 remain open pending a maintainer or ISSUES_PRS_MERGE-tier agent with .github/workflows/* write access. Closes: #6892 Refs: #6899, #6891, #6928 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: copilot-swe-agent[bot] <223556219+Copilot@users.noreply.github.com>
|
Important Held for human sign-off on the direction, not on the code. This PR's only tracked rationale is #6892, which the hive filed itself — issue #6892 was filed by kubestellar-hive[bot] and no human has acknowledged it. An agent-filed issue does not, on its own, establish that anyone agreed to the direction (hivecommons/hive#5117). The change may well be right; nothing here is a review of it. To release the hold, acknowledge the direction on that issue — comment on it, assign yourself, or add the |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
❌ Deploy Preview for kubestellar-docs failed. Why did it fail? →
|
|
Hi @kubestellar-hive[bot]. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hold released: self-authorization hold disabled by config (#5117) |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
What
runbooks/api-error-rate-latency.md: adds a cross-reference paragraph notingdashboard.json,dashboard-docs-api.json, andgrafana-dashboard.jsonvisualize the samedocs_api_requests_total/docs_api_request_duration_secondsmetrics but disagree on error definition (5xx-only vs. 4xx+5xx) and aggregation granularity — mirroring the existing cross-reference this runbook already has for the driftedPrometheusRulemanifests (added for [operations] Three drifted PrometheusRule manifests (prometheusrule.yaml, prometheusrule-docs-api.yaml, alerts.yaml) alert on the same metrics with different thresholds #6884).runbooks/contributor-profiles-failure-monitoring.md(new): documents the silent-failure gap ingenerate-leaderboard.yml'sGenerate contributor profilesstep —continue-on-error: true+ a 5-minute timeout means a crash/hang there is swallowed and never reaches the workflow's ownif: failure()alert step, so the run still shows fully green. Includes manual detection and recovery steps.runbooks/README.md: indexes the new runbook.Why
Confirmed findings: #6891 (dashboard drift) and #6899 (contributor-profiles silent failure), tracked via their companion issues #6892 and #6900.
Scope
runbooks/*.md). No dashboard JSON,PrometheusRule, or.github/workflows/*file is changed.continue-on-errorgap ingenerate-leaderboard.yml— both require a maintainer or anISSUES_PRS_MERGE-tier agent with.github/workflows/*write access, since agent tokens lack theworkflowspermission. [operations] Three drifted Grafana dashboard JSON files (dashboard.json, dashboard-docs-api.json, grafana-dashboard.json) disagree on error definition and granularity #6891 and [operations] generate-contributor-profiles.mjs step in generate-leaderboard.yml can crash silently — continue-on-error hides failures from the workflow's own alert step #6899 stay open to track that follow-up.Closes: #6892
Refs: #6899, #6891, #6928
— hive: agent=operations backend=copilot model=claude-sonnet-4-6