Skip to content

Master into develop cascade merge - #2985

Merged
rtibbles merged 38 commits into
learningequality:developfrom
rtibbles:master_into_develop
Feb 23, 2021
Merged

Master into develop cascade merge#2985
rtibbles merged 38 commits into
learningequality:developfrom
rtibbles:master_into_develop

Conversation

@rtibbles

@rtibblesrtibbles commented Feb 23, 2021

Copy link
Copy Markdown
Member

Conflicts:

  • contentcuration/contentcuration/frontend/channelEdit/views/progress/ProgressModal.vue
  • contentcuration/contentcuration/frontend/channelEdit/views/progress/tests/progressModal.spec.js

rtibblesand others added 30 commits February 4, 2021 08:36
…ion_updates
Updates to create channel internal endpoint to handle custom channel navigation creation
…e_username
Trim whitespace for email addresses
…_channels
Avoid left join when filtering for channel permissions
Allow MPTT updates when uploading tree to ensure proper order.
…e-field
Fix "randomize question order" field not being synced when toggling its checkbox in EditModal
rtibblesand others added 8 commits February 17, 2021 22:20
update stopPublish action to work also cancel sync tasks
For feedback direct users to the forum instead.
…ss-modal-titles
Fix mismatch between Progress Modal content and current task
# Conflicts:
#	contentcuration/contentcuration/frontend/channelEdit/views/progress/ProgressModal.vue
#	contentcuration/contentcuration/frontend/channelEdit/views/progress/__tests__/progressModal.spec.js

@marcellamakimarcellamaki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflicts in the Progress Modal look to be resolved correctly to me

@codecov

codecovBot commented Feb 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2985 (67913e8) into develop (07a4cdc) will increase coverage by 0.21%.
The diff coverage is 88.88%.

Impacted file tree graph

@@ Coverage Diff @@## develop #2985 +/- ##
===========================================
+ Coverage 85.53% 85.74% +0.21% 
===========================================
Files 299 298 -1 Lines 15827 15843 +16 ===========================================
+ Hits 13538 13585 +47 + Misses 2289 2258 -31 
Impacted FilesCoverage Δ
contentcuration/contentcuration/forms.py82.35% <ø> (-0.51%)⬇️
contentcuration/contentcuration/urls.py95.16% <ø> (ø)
contentcuration/contentcuration/views/settings.py74.74% <ø> (+1.59%)⬆️
...contentcuration/tests/views/test_views_internal.py97.24% <82.22%> (-2.76%)⬇️
contentcuration/contentcuration/models.py85.45% <100.00%> (+0.01%)⬆️
...curation/contentcuration/tests/views/test_users.py100.00% <100.00%> (ø)
...contentcuration/tests/viewsets/test_contentnode.py84.23% <100.00%> (+0.11%)⬆️
contentcuration/contentcuration/views/internal.py85.37% <100.00%> (+0.19%)⬆️
...ntcuration/contentcuration/viewsets/contentnode.py85.18% <100.00%> (+0.08%)⬆️
...tentcuration/contentcuration/utils/google_drive.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d68c89...d625081. Read the comment docs.

@rtibbles
rtibbles merged commit c658dee into learningequality:developFeb 23, 2021
@rtibbles
rtibbles deleted the master_into_develop branch February 23, 2021 17:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@rtibbles@marcellamaki@jredrejo@kollivier@jonboiser@radinamatic@sairina@MisRob