Release PR for Sprint ending 2021-04-12 by bjester · Pull Request #3087 · learningequality/studio

bjester · 2021-04-12T16:50:32Z

Summary

Resolves issue with filtering Content Library channels by "Starred" (Bookmark)
Resolves issue with searching for channels in Studio admin UI
Re-enables editing of channels by admin users
Other miscellaneous bug fixes

PR	Category	QA Focus
#3070	Bug fix	Starring channels and filtering by Starred
#3053	Bug fix	Channel resource navigation
#3055	Bug fix	Verify Channel list page works with Opera browser version < 56 via BrowserStack
#3051	Bug fix	Edit channel as admin without normal edit permissions
#3054	Bug fix	Search for channel as admin within admin interface
#3090	Bug fix	Publish a small channel
#3052	Security update	N/A

QA Scenarios

Starring channels and filtering by Starred (also known as bookmarking)

Log in as a non-admin user
Click on the "Content Library" tab
Star a few channels by clicking on the star icon on its card
After 10 seconds, click on the "Starred" filter checkbox on the left-hand side under "Formats" to filter all bookmarked channels
Verify the channels you previously starred are shown
Unstar a channel by clicking on the star icon on the card
Uncheck the "Starred" filter and wait 10 seconds
Click on the "Starred" filter again
Verify the unstarred channel is no longer listed

Channel resource navigation

Open an existing channel with resources
Click on a topic in the main topic view and verify it opens the topic
Click on a topic's right-arrow chevron in the main topic view and verify it opens the topic
Click on a resource in the main topic view and verify it opens its details panel

Edit channel as admin without normal edit permissions

Log onto non-production studio as an admin user
Open the Administration interface from the account navigation on the Channel List page
Open another user's channel that your user doesn't have edit permissions for
Verify the channel is not shown as "View-Only" and that you can make edits to the channel

Search for channel as admin within admin interface

Log onto studio as an admin user
Open the Administration interface from the account navigation on the Channel List page
Search for a channel
Verify channels are filtered for your search query

Publish a small channel

Open a small channel
Click Publish
You should observe a loading spinner until the resource size task completes
Verify you see the channel size once it does complete

…s-2.7.4 Bump pygments from 2.5.2 to 2.7.4

Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com>

Check event has a target before checking the target tagName.

…n/y18n-3.2.2 Bump y18n from 3.2.1 to 3.2.2

Merge Sprint release 2021-03-29 back into hotfixes

…03-29 Merge pull request #3062 from learningequality/sprint-release-2021-03-29

Enable admin editing of channels in the UI.

Don't pass unsanitized inputs into regex.

codecov · 2021-04-12T18:59:01Z

Codecov Report

Merging #3087 (7ddca73) into master (c04ed76) will increase coverage by 0.03%.
The diff coverage is 92.47%.

❗ Current head 7ddca73 differs from pull request most recent head 516d79d. Consider uploading reports for the commit 516d79d to get more accurate results

@@ Coverage Diff @@## master #3087 +/- ##
==========================================
+ Coverage 85.93% 85.96% +0.03% 
==========================================
Files 304 305 +1 Lines 16403 16478 +75 ==========================================
+ Hits 14096 14166 +70 - Misses 2307 2312 +5

Impacted Files	Coverage Δ
contentcuration/contentcuration/tasks.py	`60.34% <ø> (+2.71%)`	⬆️
contentcuration/contentcuration/utils/user.py	`72.72% <70.00%> (-27.28%)`	⬇️
...ontentcuration/contentcuration/viewsets/channel.py	`80.53% <85.18%> (+0.78%)`	⬆️
contentcuration/contentcuration/models.py	`84.58% <100.00%> (ø)`
...curation/contentcuration/tests/utils/test_nodes.py	`95.19% <100.00%> (-4.81%)`	⬇️
...ion/contentcuration/tests/viewsets/test_channel.py	`94.17% <100.00%> (+1.26%)`	⬆️
contentcuration/contentcuration/utils/nodes.py	`83.81% <100.00%> (-0.63%)`	⬇️
...ontentcuration/contentcuration/utils/pagination.py	`81.81% <0.00%> (-2.28%)`	⬇️
...tentcuration/migrations/0123_auto_20210407_0057.py	`100.00% <0.00%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04ed76...516d79d. Read the comment docs.

Fix star/bookmarking feature in Content Library

Quick change to disable synchronous calculation of resource size

radinamatic · 2021-04-14T22:20:53Z

PR	Category	Comment	Status
#3070	Bug fix	Starring channels and filtering by Starred	Fixed ✔️
#3053	Bug fix	Channel resource navigation	Fixed ✔️
#3055	Bug fix	Verify Channel list page works with Opera browser version < 56 via BrowserStack	Fixed ✔️
#3051	Bug fix	Edit channel as admin without normal edit permissions	Fixed ✔️
#3054	Bug fix	Search for channel as admin within admin interface	Fixed ✔️
#3090	Bug fix	Publish a small channel	Fixed ✔️

We are good to go!!! 💯 👏🏽

radinamatic

Merge away! 💥

rtibblesand others added 13 commits March 29, 2021 14:31

Enable admin editing of channels in the UI.
4a1aca9

Check event has a target before checking the target tagName.
8d8d2c2

Don't pass unsanitized inputs into regex.
5c54628

Use 'usage' to ensure polyfills.
6d35dfe

Merge pull request#3052from learningequality/dependabot/pip/pygment…
3e15315
…s-2.7.4 Bump pygments from 2.5.2 to 2.7.4

Remove corejs from tests. Remove proposal only use of lastItem.
436b202

Merge pull request#3055from rtibbles/polyfill_usage
f43a78c

Merge pull request#3053from rtibbles/tagname
3c74632
Check event has a target before checking the target tagName.

Merge pull request#3057from learningequality/dependabot/npm_and_yar…
11c854c
…n/y18n-3.2.2 Bump y18n from 3.2.1 to 3.2.2

Merge pull request#3068from learningequality/sprint-release-2021-03-29
e6aaf0d
Merge Sprint release 2021-03-29 back into hotfixes

Merge pull request#3072from learningequality/sprint-release-2021-03-29
1751f45
Merge Sprint release 2021-03-29 back into hotfixes

Merge pull request#3073from bjester/merge-down-sprint-release-2021-…
016aa65
…03-29 Merge pull request #3062 from learningequality/sprint-release-2021-03-29

bjester changed the title ~~Release for Sprint 2021-04-12~~Release PR for Sprint ending 2021-04-12Apr 12, 2021

sairinaand others added 7 commits April 12, 2021 11:37

Initial update to tests and bookmark saving
48af864

Merge pull request#3051from rtibbles/admin_edit
b709012
Enable admin editing of channels in the UI.

Add ChannelListPagination class for ChannelViewSet
cf0a1fa

Add test for viewer editing bookmarked public channel
b4abe6d

Fix tests and add fix bookmark mods for serializer
eb01677

Add docstring to update_from_changes method
dd077ae

Merge pull request#3054from rtibbles/admin_channels
46e83fd
Don't pass unsanitized inputs into regex.

Merge pull request#3070from sairina/starred
7ddca73
Fix star/bookmarking feature in Content Library

bjester marked this pull request as ready for review April 12, 2021 19:54

bjester added this to the Sprint 2021-04-12 milestone Apr 12, 2021

bjester added 3 commits April 12, 2021 13:19

Quick change to disable synchronous calculation of resource size
7ca1fb4

Add patch for constant to viewset test
367e008

Merge pull request#3090from bjester/disable-sync-resource-size-calc
516d79d
Quick change to disable synchronous calculation of resource size

bjester requested review from radinamatic and rtibbles April 12, 2021 21:48

bjester added the TODO: needs review label Apr 12, 2021

radinamatic approved these changes Apr 14, 2021
View reviewed changes

rtibbles approved these changes Apr 14, 2021
View reviewed changes

rtibbles merged commit d2892c8 into masterApr 15, 2021

Navigation Menu

Uh oh!

Uh oh!

Release PR for Sprint ending 2021-04-12 - #3087

Release PR for Sprint ending 2021-04-12#3087
rtibbles merged 24 commits into
masterfrom
hotfixes

bjester commented Apr 12, 2021•
edited
Loading

Uh oh!

codecovBot commented Apr 12, 2021•
edited
Loading

Uh oh!

radinamatic commented Apr 14, 2021

Uh oh!

radinamatic left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

bjester commented Apr 12, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

QA Scenarios

Starring channels and filtering by Starred (also known as bookmarking)

Channel resource navigation

Edit channel as admin without normal edit permissions

Search for channel as admin within admin interface

Publish a small channel

Uh oh!

codecovBot commented Apr 12, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

radinamatic commented Apr 14, 2021

Uh oh!

radinamatic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bjester commented Apr 12, 2021•
edited
Loading

codecovBot commented Apr 12, 2021•
edited
Loading