Uh oh!
There was an error while loading. Please reload this page.
Quick change to disable synchronous calculation of resource size - #3090
Conversation
Codecov Report
@@ Coverage Diff @@## hotfixes #3090 +/- ##
============================================
- Coverage 85.96% 85.96% -0.01%
============================================
Files 305 304 -1 Lines 16478 16474 -4 ============================================
- Hits 14166 14162 -4
Misses 2312 2312
Continue to review full report at Codecov.
|
pcenov
commented
Apr 13, 2021
@bjester, after testing this change I can confirm that the the channel size is displayed now in the modal window. However for some reason it takes a lot of time before that happens even for a very small channel and I have an excellent internet connection. |
radinamatic
commented
Apr 14, 2021
Confirming the findings by @pcenov: it takes almost 2 minutes to get the channel size calculated and for spinner to disappear on both channel with 82 resources and the one with just 2 resources 🤔 |
bjester
commented
Apr 15, 2021
@pcenov@radinamatic Thank you for your testing insights! That is indeed a longer wait than expected. This change removed the synchronous calculation which forces the calculation to be queued for our async task workers. If there are a lot of tasks in the queue, that will slow down the processing, which is difficult to get a realistic read in a local development environment. Therefore it does seem that we should reinstate synchronous processing, but we should decrease the threshold from 5000 resources. I'll plan a follow up for next release! |

Summary
Synchronous calculations of resource size are taking too long.
Description of the change(s) you made
Changes the constant used to determine whether it should try calculation synchronously or not such that it shouldn't try to do so
Manual verification steps performed
References
Addresses: #3084
Follow up: #3089
Gherkin: integration_testing/features/publish-channel.feature
Contributor's Checklist
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)