Skip to content

Save numerical input answers - #4945

Closed
akolson wants to merge 2 commits into
learningequality:unstablefrom
akolson:save-numerical-input-answers
Closed

Save numerical input answers#4945
akolson wants to merge 2 commits into
learningequality:unstablefrom
akolson:save-numerical-input-answers

Conversation

@akolson

Copy link
Copy Markdown
Member

Summary

This pr fixes a bug where a numeric input answer is not saved and question is marked as incomplete after closing the exercise editor.

Before

num-input.mp4

After

Screen.Recording.2025-03-11.at.08.42.30.mov

References

Fixes#4910

Reviewer guidance

  1. Select Numeric input type of question in the exercise editor.
  2. Add 1 answer and close the editor.
  3. Reopen the exercise and ensure the ❗ mark indicating the incomplete question is not displayed
  4. Try different variations as illustrated in the before video to check if the issue can be replicated

@akolsonakolson added this to the Studio: 2025 Q1 Patch 1 milestone Mar 11, 2025
@rtibblesrtibbles self-assigned this Mar 11, 2025
@rtibbles
rtibbles changed the base branch from unstable to hotfixesMarch 11, 2025 20:20
@rtibbles
rtibbles changed the base branch from hotfixes to unstableMarch 11, 2025 20:20

@rtibblesrtibbles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any issues in my testing, and I think whatever extra caution we initially had that added this catch in the first place is no longer required.

One thing is that we should rebase this on top of hotfixes rather than unstable and target the PR there, so we can release it as a patch.

@akolson

akolson commented Mar 12, 2025

Copy link
Copy Markdown
MemberAuthor

New pr pointing to hotfixes. Closing this cc @rtibbles

@akolsonakolson closed this Mar 12, 2025
@akolson
akolson deleted the save-numerical-input-answers branch March 12, 2025 14:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Numeric input answer is not saved and question is marked as incomplete after closing the exercise editor

2 participants

@akolson@rtibbles