Skip to content

Save numerical input answers - #4957

Merged
akolson merged 2 commits into
learningequality:hotfixesfrom
akolson:save-numerical-input-answers-fix
Mar 12, 2025
Merged

Save numerical input answers#4957
akolson merged 2 commits into
learningequality:hotfixesfrom
akolson:save-numerical-input-answers-fix

Conversation

@akolson

Copy link
Copy Markdown
Member

Summary

This pr fixes a bug where a numeric input answer is not saved and question is marked as incomplete after closing the exercise editor.

Before

num-input.mp4

After

Screen.Recording.2025-03-11.at.08.42.30.mov

References

Fixes#4910

Reviewer guidance

  1. Select Numeric input type of question in the exercise editor.
  2. Add 1 answer and close the editor.
  3. Reopen the exercise and ensure the ❗ mark indicating the incomplete question is not displayed
  4. Try different variations as illustrated in the before video to check if the issue can be replicated

@akolson
akolson merged commit 552ce91 into learningequality:hotfixesMar 12, 2025
@akolson

Copy link
Copy Markdown
MemberAuthor

Hi @pcenov@radinamatic. Fix should be testable via hotfixes. Thanks

@radinamatic

radinamatic commented Mar 17, 2025

Copy link
Copy Markdown
Member

Numerical input answer is now being saved correctly, and no other issues and regressions are observed.

num-input

Can someone just remind me if it's according to spec that it can have multiple (right) answers? 🤔 cc @jtamiace
Confirmed! 👍🏽

@akolson
akolson deleted the save-numerical-input-answers-fix branch January 9, 2026 11:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@akolson@radinamatic@rtibbles