Skip to content

Ensure that file_format and preset match during file_upload requests. - #5040

Merged
bjester merged 1 commit into
learningequality:unstablefrom
rtibbles:matchy_matchy
Aug 13, 2025
Merged

Ensure that file_format and preset match during file_upload requests.#5040
bjester merged 1 commit into
learningequality:unstablefrom
rtibbles:matchy_matchy

Conversation

@rtibbles

@rtibblesrtibbles commented May 1, 2025

Copy link
Copy Markdown
Member

Summary

  • Adds a small validation check to file uploads to ensure that we don't allow uploads of files with mismatched file formats and format presets
  • Adds/updates tests for the same

@rtibblesrtibbles mentioned this pull request May 1, 2025
Closed
bjester
bjester approved these changes Aug 13, 2025
View reviewed changes

@bjesterbjester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester
bjester merged commit c332afa into learningequality:unstableAug 13, 2025
@bjesterbjester mentioned this pull request Aug 14, 2025
Merged
@bjesterbjester mentioned this pull request Aug 22, 2025
Merged
@rtibbles
rtibbles deleted the matchy_matchy branch September 25, 2025 03:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjesterbjesterbjester approved these changes

Assignees

@ozer550ozer550

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rtibbles@bjester@ozer550