Uh oh!
There was an error while loading. Please reload this page.
Feedback utility functions - #5088
Conversation
ozer550
left a comment
There was a problem hiding this comment.
Logically, everything in the code makes sense! Just a few small tweaks and some debugging is needed to resolve the UI issues encountered during testing. Additionally, I have a few thoughts on potential optimizations we could explore further.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
a8759bb to
02b5952Compare
bjester
left a comment
There was a problem hiding this comment.
Unless I'm missing something, the event ordering seems misaligned.
Additionally, there's a confusing mix of async/await, old-style Promise chaining, and some ignored promises. I suggest some consistency, with code comments for explaining the purposes of any inconsistencies-- if a promise is ignored, give a reason. For new code, I see no reason not to use async/await
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
5e48e3d to
c793fc9Compare…t during pagination
Summary
This pr does the following;
References
Fixes#5057
Fixes#5058
Fixes#5088
Reviewer guidance
RecommendationsEventandRecommendationsInteractionEventmodels