Skip to content

Fix Edit language modal not closing immediately - #5363

Merged
akolson merged 1 commit into
learningequality:hotfixesfrom
ozer550:fix-edit-modal-not-closing-immediately
Sep 4, 2025
Merged

Fix Edit language modal not closing immediately#5363
akolson merged 1 commit into
learningequality:hotfixesfrom
ozer550:fix-edit-modal-not-closing-immediately

Conversation

@ozer550

@ozer550ozer550 commented Sep 4, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Fixes the 'Edit language' modal not closing immediately after saving the changes.

References

closes#5348

Reviewer guidance

  • Go to a channel and select a folder or a resource
  • Click the Edit language icon
  • Select a language and click the Save button
  • The modal now closes immediately!

@ozer550ozer550 changed the title remove await from showSnackbarSimple callFix Edit language modal not closing immediatelySep 4, 2025
@ozer550
ozer550 requested a review from akolsonSeptember 4, 2025 05:03
akolson
akolson approved these changes Sep 4, 2025
View reviewed changes

@akolsonakolson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Manual QA also checks out. Thanks @ozer550

@akolson
akolson merged commit d800cfa into learningequality:hotfixesSep 4, 2025
14 checks passed
This was referenced Sep 4, 2025
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akolsonakolsonakolson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ozer550@akolson