Skip to content

Set / get supported extensions - #1908

Merged
bording merged 6 commits into
libgit2:masterfrom
jairbubbles:set-get-supported-extensions
Dec 29, 2021
Merged

Set / get supported extensions#1908
bording merged 6 commits into
libgit2:masterfrom
jairbubbles:set-get-supported-extensions

Conversation

@jairbubbles

@jairbubblesjairbubbles commented Sep 11, 2021

Copy link
Copy Markdown
Contributor

(I'm not sure at all for the P/Invoke code)

@jairbubbles

jairbubbles commented Sep 29, 2021

Copy link
Copy Markdown
ContributorAuthor

@skysb@alfonsarmi Once this is merged you'll be able to open blobless repositories by calling GlobalSettings.SetExtensions("partialclone"); prior to opening any repositories.

Many methods can throw unexpectedly and my goal is to make it more confortable in
#1909. Please let me know your thoughts and what would be the best for your use case. Please note that I only plan to support blobless repositories (see https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/)

@bording Is there some place where doc could be added regarding the support of partially cloned repositories? I believe this will be more and more a question as the usage of this feature grows.

@jairbubbles
jairbubblesforce-pushed the set-get-supported-extensions branch from f37eb52 to c25bc4bCompareSeptember 29, 2021 07:45
@skysb

skysb commented Oct 6, 2021

Copy link
Copy Markdown

Hi @jairbubbles
That sounds great! Would a nuget be created so we can download and test it out, anytime soon?
In terms of #1909 I only intend to use it for blobless repositories or filtering out with patterns. Eitherways, in my use case, all I needed was to be able to instantiate the repository, as all data related to files and trees is already available in that. As long as I can read that high level data, we wouldn't need a more extensive research.

We had tried it on windows and it allowed us to get the tree data so it should be more than sufficient as of now. But Id still like to test it out to see if I'm missing any scenarios.

Cheers

@jairbubbles

Copy link
Copy Markdown
ContributorAuthor

Hi @skysb, I'm not maintainer so we just need to wait just a bit.

@jairbubbles

Copy link
Copy Markdown
ContributorAuthor

Hi @bording, would you have time to look at this? The changes are quite simple and it would unlock new possibilities. Thx!

@bording

Copy link
Copy Markdown
Member

Hi @bording, would you have time to look at this? The changes are quite simple and it would unlock new possibilities. Thx!

Your PRs are definitely on my todo list once I get all the changes from going back to the native HTTPS support finished.

@skysb

Copy link
Copy Markdown

@bording Hi, any ETC for this?

Comment threadLibGit2Sharp/Core/NativeMethods.cs Outdated
@bording

Copy link
Copy Markdown
Member

@jairbubbles Please rebase the PR to resolve the conflicts!

@jairbubbles
jairbubblesforce-pushed the set-get-supported-extensions branch from c25bc4b to 5b92d55CompareNovember 22, 2021 09:30
@jairbubbles

Copy link
Copy Markdown
ContributorAuthor

@bording There seem to be some flakiness on some jobs. I don't know if it's related to my change. See https://github.com/libgit2/libgit2sharp/runs/4285262042?check_suite_focus=true

@bording
bording merged commit 653e9bb into libgit2:masterDec 29, 2021
@jairbubbles

Copy link
Copy Markdown
ContributorAuthor

Thx @bording, let me know when you publish a package with the changes.

@bording

Copy link
Copy Markdown
Member

Thanks for the PR! I've pushed 0.27.0-preview-0175 to nuget.org, which includes these changes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jairbubbles@skysb@bording