Skip to content

Simplify dealing with missing git objects - #1909

Merged
bording merged 1 commit into
libgit2:masterfrom
jairbubbles:support-for-blobless-repositories
Dec 29, 2021
Merged

Simplify dealing with missing git objects#1909
bording merged 1 commit into
libgit2:masterfrom
jairbubbles:support-for-blobless-repositories

Conversation

@jairbubbles

@jairbubblesjairbubbles commented Sep 12, 2021

Copy link
Copy Markdown
Contributor
  • Add IsMissing on GitObject to know if a git objects is missing without any exception involved
  • Make some methods on Blob and Tree explicitly throw a NotFoundException (rather than a NullReferenceException later on when accessing the null handle)

@jairbubbles

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Sep 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1909 (c423ad1) into master (6329bea) will decrease coverage by 0.03%.
The diff coverage is 61.53%.

Impacted file tree graph

@@ Coverage Diff @@## master #1909 +/- ##
==========================================
- Coverage 84.80% 84.76% -0.04% 
==========================================
Files 231 231 Lines 9120 9130 +10 ==========================================
+ Hits 7734 7739 +5 - Misses 1386 1391 +5 
Impacted FilesCoverage Δ
LibGit2Sharp/Core/Proxy.cs93.85% <55.55%> (-0.28%)⬇️
LibGit2Sharp/Blob.cs95.45% <75.00%> (-4.55%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6329bea...c423ad1. Read the comment docs.

@jairbubbles
jairbubblesforce-pushed the support-for-blobless-repositories branch 2 times, most recently from bcf3892 to 8c8af89CompareOctober 3, 2021 17:23
@jairbubblesjairbubbles changed the title Support for blobless repositoriesSimplify dealing with missing git objectsOct 3, 2021
@jairbubbles
jairbubblesforce-pushed the support-for-blobless-repositories branch from 8c8af89 to a06c37dCompareOctober 3, 2021 18:12
@jairbubbles
jairbubbles marked this pull request as ready for review October 3, 2021 18:19
@jairbubbles
jairbubblesforce-pushed the support-for-blobless-repositories branch 3 times, most recently from 8cf1d35 to 243ba03CompareOctober 3, 2021 19:02
@jairbubbles
jairbubblesforce-pushed the support-for-blobless-repositories branch from 243ba03 to b05a00fCompareNovember 22, 2021 10:36
@bording
bording merged commit e00da45 into libgit2:masterDec 29, 2021
@bording

Copy link
Copy Markdown
Member

Thanks for the PR! I've pushed 0.27.0-preview-0175 to nuget.org, which includes these changes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jairbubbles@codecov-commenter@bording